lib/baw-workers/mail/mailer.rb
Method error_notification
has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring. Open
Open
def error_notification(to, from, job, error)
fail ArgumentError, "Error is not a ruby error object #{error.inspect}." unless error.is_a?(StandardError)
fail ArgumentError, "From is not a string #{from.inspect}." unless from.is_a?(String)
fail ArgumentError, "To is not a string or Array #{to.inspect}." unless (to.is_a?(String) || to.is_a?(Array))
fail ArgumentError, "Job is not a hash #{job.inspect}." unless job.is_a?(Hash)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method error_notification
has 42 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
def error_notification(to, from, job, error)
fail ArgumentError, "Error is not a ruby error object #{error.inspect}." unless error.is_a?(StandardError)
fail ArgumentError, "From is not a string #{from.inspect}." unless from.is_a?(String)
fail ArgumentError, "To is not a string or Array #{to.inspect}." unless (to.is_a?(String) || to.is_a?(Array))
fail ArgumentError, "Job is not a hash #{job.inspect}." unless job.is_a?(Hash)