Sign upLogin

RAR1741/RA19_RobotCode

View on GitHub
Star

Showing 10 of 10 total issues

Method humanControl has a Cognitive Complexity of 22 (exceeds 7 allowed). Consider refactoring.
Open

  private void humanControl() {
    // Run teleop code (interpreting input, etc.)
    double turnInput = driver.getX(Hand.kRight);
    double speedInput = driver.getY(Hand.kLeft);
Severity: Minor
Found in src/main/java/frc/robot/Robot.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File Robot.java has 270 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * Copyright (c) 2017-2018 FIRST. All Rights Reserved. Open Source Software - may be modified and
 * shared by FRC teams. The code must be accompanied by the FIRST BSD license file in the root
 * directory of the project.
 */
Severity: Minor
Found in src/main/java/frc/robot/Robot.java - About 2 hrs to fix

    Method humanControl has 60 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      private void humanControl() {
    // Run teleop code (interpreting input, etc.)
    double turnInput = driver.getX(Hand.kRight);
    double speedInput = driver.getY(Hand.kLeft);
    Severity: Major
    Found in src/main/java/frc/robot/Robot.java - About 2 hrs to fix

      Method robotInit has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        @Override
  public void robotInit() {
    logger.info("Initializing robot...");

    logger.info("Starting timer...");
      Severity: Minor
      Found in src/main/java/frc/robot/Robot.java - About 2 hrs to fix

        Method log has a Cognitive Complexity of 11 (exceeds 7 allowed). Consider refactoring.
        Open

          @Override
  public void log(DataLogger logger) {
    logger.log("navx_Pitch", getPitch());
    logger.log("navx_Roll", getRoll());
    logger.log("navx_Yaw", getYaw());
        Severity: Minor
        Found in src/main/java/frc/robot/loggable/LoggableNavX.java - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            try {
      for (Map.Entry<String, String> e : fields.entrySet()) {
        log.write(e.getKey() + ',');
      }
      log.write("\n");
        Severity: Minor
        Found in src/main/java/frc/robot/logging/DataLogger.java and 1 other location - About 30 mins to fix
        src/main/java/frc/robot/logging/DataLogger.java on lines 151..157

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 42.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            try {
      for (Map.Entry<String, String> e : fields.entrySet()) {
        log.write(e.getValue() + ',');
      }
      log.write("\n");
        Severity: Minor
        Found in src/main/java/frc/robot/logging/DataLogger.java and 1 other location - About 30 mins to fix
        src/main/java/frc/robot/logging/DataLogger.java on lines 132..138

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 42.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              if (driver.getTriggerAxis(Hand.kLeft) >= 0.5) {
        turnInput = inputTransformer.transformClimb(turnInput);
        turnInput = inputTransformer.transformClimb(speedInput);
      }
        Severity: Minor
        Found in src/main/java/frc/robot/Robot.java and 1 other location - About 30 mins to fix
        src/main/java/frc/robot/Robot.java on lines 337..340

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 40.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              if (driver.getTriggerAxis(Hand.kRight) < 0.5) {
        turnInput = inputTransformer.transformDrive(turnInput);
        speedInput = inputTransformer.transformDrive(speedInput);
      }
        Severity: Minor
        Found in src/main/java/frc/robot/Robot.java and 1 other location - About 30 mins to fix
        src/main/java/frc/robot/Robot.java on lines 341..344

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 40.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method log has a Cognitive Complexity of 8 (exceeds 7 allowed). Consider refactoring.
        Open

          public void log(DataLogger logger) {
    logger.log(getName() + "LeftX", this.getX(Hand.kLeft));
    logger.log(getName() + "LeftY", this.getY(Hand.kLeft));
    logger.log(getName() + "RightX", this.getX(Hand.kRight));
    logger.log(getName() + "RightY", this.getY(Hand.kRight));
        Severity: Minor
        Found in src/main/java/frc/robot/loggable/LoggableXboxController.java - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language