Sign upLogin

RAR1741/RA19_RobotCode

View on GitHub
Star

Showing 6 of 10 total issues

Method humanControl has a Cognitive Complexity of 22 (exceeds 7 allowed). Consider refactoring.
Open

  private void humanControl() {
    // Run teleop code (interpreting input, etc.)
    double turnInput = driver.getX(Hand.kRight);
    double speedInput = driver.getY(Hand.kLeft);
Severity: Minor
Found in src/main/java/frc/robot/Robot.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File Robot.java has 270 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * Copyright (c) 2017-2018 FIRST. All Rights Reserved. Open Source Software - may be modified and
 * shared by FRC teams. The code must be accompanied by the FIRST BSD license file in the root
 * directory of the project.
 */
Severity: Minor
Found in src/main/java/frc/robot/Robot.java - About 2 hrs to fix

    Method humanControl has 60 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      private void humanControl() {
    // Run teleop code (interpreting input, etc.)
    double turnInput = driver.getX(Hand.kRight);
    double speedInput = driver.getY(Hand.kLeft);
    Severity: Major
    Found in src/main/java/frc/robot/Robot.java - About 2 hrs to fix

      Method robotInit has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        @Override
  public void robotInit() {
    logger.info("Initializing robot...");

    logger.info("Starting timer...");
      Severity: Minor
      Found in src/main/java/frc/robot/Robot.java - About 2 hrs to fix

        Method log has a Cognitive Complexity of 11 (exceeds 7 allowed). Consider refactoring.
        Open

          @Override
  public void log(DataLogger logger) {
    logger.log("navx_Pitch", getPitch());
    logger.log("navx_Roll", getRoll());
    logger.log("navx_Yaw", getYaw());
        Severity: Minor
        Found in src/main/java/frc/robot/loggable/LoggableNavX.java - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method log has a Cognitive Complexity of 8 (exceeds 7 allowed). Consider refactoring.
        Open

          public void log(DataLogger logger) {
    logger.log(getName() + "LeftX", this.getX(Hand.kLeft));
    logger.log(getName() + "LeftY", this.getY(Hand.kLeft));
    logger.log(getName() + "RightX", this.getX(Hand.kRight));
    logger.log(getName() + "RightY", this.getY(Hand.kRight));
        Severity: Minor
        Found in src/main/java/frc/robot/loggable/LoggableXboxController.java - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language