RackHD/on-core

Function arpCacheFactory has 71 lines of code (exceeds 25 allowed). Consider refactoring.

Open

function arpCacheFactory(
    Logger,
    Promise,
    assert,
    util,

Function getCurrent has 36 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    ARPCache.prototype.getCurrent = function() {
        var self = this;
        return self.parseArpCache()
        .then(function(data) {
            self.current = data;

Function arpCacheFactory has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

    Logger,
    Promise,
    assert,
    util,
    _,

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            var updated = _.merge(_(self.last)
            .filter(function(e) {
                return _.isUndefined(_.find(self.current, e));
            })
            .value(), _(self.current)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            .value(), _(self.current)
            .filter(function(e) {
                return _.isUndefined(_.find(self.last, e));
            })
            .value());

• Read up
  Read up