Sign upLogin

RackHD/on-core

View on GitHub
Star
lib/common/http-tool.js

Summary

Maintainability
D
2 days
Test Coverage

Function HttpFactory has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
Open

function HttpFactory(assert, Promise, _) {
    
    /**
    * Tool class that does HTTP methods
    * @constructor
Severity: Minor
Found in lib/common/http-tool.js - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function HttpFactory has 136 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function HttpFactory(assert, Promise, _) {
    
    /**
    * Tool class that does HTTP methods
    * @constructor
Severity: Major
Found in lib/common/http-tool.js - About 5 hrs to fix

    Function HttpTool has 69 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function HttpTool(){
        this.settings = {};
        this.urlObject = {};
        this.dataToWrite = '';
        // ********** Helper Functions/Members **********
    Severity: Major
    Found in lib/common/http-tool.js - About 2 hrs to fix

      Function setupUrlOptions has 48 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              this.setupUrlOptions = function(settings) {
                
            var urlTool = require('url');
            var urlObject = {};
      Severity: Minor
      Found in lib/common/http-tool.js - About 1 hr to fix

        Function runRequest has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            HttpTool.prototype.runRequest = function() {
        var httpTool;
        var self = this;
        var toolName = 'http';
        Severity: Minor
        Found in lib/common/http-tool.js - About 1 hr to fix

          Avoid too many return statements within this function.
          Open

                      return true;
          Severity: Major
          Found in lib/common/http-tool.js - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status