Sign upLogin

RackHD/on-core

View on GitHub
Star
lib/di.js

Summary

Maintainability
F
3 days
Test Coverage

Function setupDiHelper has a Cognitive Complexity of 81 (exceeds 5 allowed). Consider refactoring.
Open

function setupDiHelper(di, defaultDirectory) {
  var resolve = require('resolve'),
      _ = require('lodash'),
      glob = require('glob');
Severity: Minor
Found in lib/di.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function setupDiHelper has 273 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function setupDiHelper(di, defaultDirectory) {
  var resolve = require('resolve'),
      _ = require('lodash'),
      glob = require('glob');
Severity: Major
Found in lib/di.js - About 1 day to fix

    File di.js has 277 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    // Copyright 2015, EMC, Inc.
/*global __dirname:false*/

'use strict';
/**
    Severity: Minor
    Found in lib/di.js - About 2 hrs to fix

      Consider simplifying this complex logical expression.
      Open

            if(isFunction(obj) && (exists(obj.$provide) || exists(obj.$inject) || provide || injects)){
        var instance = Object.create(obj.prototype);
        return obj.apply(instance,arguments) || instance;
      }
      Severity: Major
      Found in lib/di.js - About 40 mins to fix

        Function _wrapper has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          function _wrapper(originalObject, wrappedObject, provide, injects, isTransientScope) {
        Severity: Minor
        Found in lib/di.js - About 35 mins to fix

          Function _require has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            function _require(requireMe, provides, injects, currentDirectory, next) {
          Severity: Minor
          Found in lib/di.js - About 35 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              function provideName(obj, token){
    if(!isString(token)) {
      throw new Error('Must provide string as name of module');
    }
    di.annotate(obj, new di.Provide(token));
            Severity: Minor
            Found in lib/di.js and 1 other location - About 55 mins to fix
            lib/di.js on lines 263..268

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 54.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              function providePromise(obj, providePromiseName) {
    if(!isString(providePromiseName)) {
      throw new Error('Must provide string as name of promised module');
    }
    di.annotate(obj, new di.ProvidePromise(providePromiseName));
            Severity: Minor
            Found in lib/di.js and 1 other location - About 55 mins to fix
            lib/di.js on lines 251..256

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 54.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status