Sign upLogin

RackHD/on-core

View on GitHub
Star
lib/models/lookup.js

Summary

Maintainability
C
1 day
Test Coverage

Function LookupModelFactory has 163 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function LookupModelFactory (
    waterline,
    Model,
    assert,
    Errors,
Severity: Major
Found in lib/models/lookup.js - About 6 hrs to fix

    Function LookupModelFactory has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

    function LookupModelFactory (
    waterline,
    Model,
    assert,
    Errors,
    Severity: Minor
    Found in lib/models/lookup.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function setIpMongo has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            setIpMongo: function(ipAddress, macAddress) {
            var query = {
                ipAddress: ipAddress,
                macAddress: { $ne: macAddress } // old mac
            };
    Severity: Minor
    Found in lib/models/lookup.js - About 1 hr to fix

      Function upsertNodeToMacAddress has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              upsertNodeToMacAddress: function (node, macAddress) {
            var self = this;
            assert.string(node, 'node');
            assert.string(macAddress, 'macAddress');
      Severity: Minor
      Found in lib/models/lookup.js - About 1 hr to fix

        Function LookupModelFactory has 9 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            waterline,
    Model,
    assert,
    Errors,
    Promise,
        Severity: Major
        Found in lib/models/lookup.js - About 1 hr to fix

          There are no issues that match your filters.

          Category
          Status