Sign upLogin

RackHD/on-core

View on GitHub
Star
lib/models/node.js

Summary

Maintainability
D
2 days
Test Coverage

Function NodeModelFactory has 171 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function NodeModelFactory (
    Model,
    waterline,
    _,
    Promise,
Severity: Major
Found in lib/models/node.js - About 6 hrs to fix

    Function remTags has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            remTags: function(id, tag) {
            var self = this;
            var dbType = _.first(self.connection);
            switch(dbType) {
            case 'mongo':
    Severity: Minor
    Found in lib/models/node.js - About 1 hr to fix

      Function addTags has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              addTags: function(id, tags) {
            var self = this;
            var dbType = _.first(self.connection);
            switch(dbType) {
            case 'mongo':
      Severity: Minor
      Found in lib/models/node.js - About 1 hr to fix

        Function NodeModelFactory has 8 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            Model,
    waterline,
    _,
    Promise,
    Constants,
        Severity: Major
        Found in lib/models/node.js - About 1 hr to fix

          Function NodeModelFactory has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

          function NodeModelFactory (
    Model,
    waterline,
    _,
    Promise,
          Severity: Minor
          Found in lib/models/node.js - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          return self.postgresqlRunLockedQuery('' +
                    'WITH t as (select array_agg(elem::text) from nodes, json_array_elements(nodes.tags::json) elem where id = $2), ' + //jshint ignore: line
                    's as (select distinct unnest(array_cat(t.array_agg, ARRAY[$1])) from t) ' +
                    'UPDATE nodes SET tags = concat( \'[\', (select string_agg(unnest,\',\') from s), \']\'),"updatedAt"=$3 WHERE id = $2',//jshint ignore: line
          Severity: Major
          Found in lib/models/node.js and 1 other location - About 2 hrs to fix
          lib/models/node.js on lines 182..195

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 82.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          return self.postgresqlRunLockedQuery('' +
                    'WITH t as (select array_agg(elem::text) from nodes, json_array_elements(nodes.tags::json) elem where id = $2), ' + //jshint ignore: line
                    's as (select distinct unnest(array_remove(t.array_agg, $1)) from t) ' +
                    'UPDATE nodes SET tags = concat( \'[\', (select string_agg(unnest,\',\') from s), \']\'),"updatedAt"=$3 WHERE id = $2', //jshint ignore: line
                    [ JSON.stringify(tag), id, new Date()])
          Severity: Major
          Found in lib/models/node.js and 1 other location - About 2 hrs to fix
          lib/models/node.js on lines 142..156

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 82.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          return self.findAndModifyMongo(query, {}, update, options)
                .then(function(record) {
                    record.id = record._id;
                    waterlineProtocol.publishRecord(self, 'updated', record);
                    waterlineProtocol.publishRecord(self, 'tag-removed', record);
          Severity: Major
          Found in lib/models/node.js and 1 other location - About 1 hr to fix
          lib/models/node.js on lines 131..137

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 73.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          return self.findAndModifyMongo(query, {}, update, options)
                .then(function(record) {
                    record.id = record._id;
                    waterlineProtocol.publishRecord(self, 'updated', record);
                    waterlineProtocol.publishRecord(self, 'tag-added', record);
          Severity: Major
          Found in lib/models/node.js and 1 other location - About 1 hr to fix
          lib/models/node.js on lines 171..177

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 73.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status