Sign upLogin

RackHD/on-core

View on GitHub
Star
lib/models/work-item.js

Summary

Maintainability
D
2 days
Test Coverage

Function WorkItemModelFactory has 228 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function WorkItemModelFactory (
    Model,
    _,
    Promise,
    assert,
Severity: Major
Found in lib/models/work-item.js - About 1 day to fix

    Function WorkItemModelFactory has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

    function WorkItemModelFactory (
    Model,
    _,
    Promise,
    assert,
    Severity: Minor
    Found in lib/models/work-item.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File work-item.js has 252 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    // Copyright (c) 2015, EMC Corporation

'use strict';

module.exports = WorkItemModelFactory;
    Severity: Minor
    Found in lib/models/work-item.js - About 2 hrs to fix

      Function setSucceeded has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              setSucceeded: function setSucceeded(leaseToken, alertMessage, workItems) {
            var self = this;
            var newState = "accessible";
            if (!Array.isArray(workItems)) {
                workItems = Array.prototype.slice.call(arguments, 2);
      Severity: Minor
      Found in lib/models/work-item.js - About 1 hr to fix

        Function setFailed has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                setFailed: function setFailed(leaseToken, alertMessage, workItems) {
            var self = this;
            var newState = "inaccessible";
            if (!Array.isArray(workItems)) {
                workItems = Array.prototype.slice.call(arguments, 2);
        Severity: Minor
        Found in lib/models/work-item.js - About 1 hr to fix

          Function WorkItemModelFactory has 8 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              Model,
    _,
    Promise,
    assert,
    Constants,
          Severity: Major
          Found in lib/models/work-item.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            return taskGraphStore.updatePollerStatus(workItem.id, {
                    status: Constants.Task.States.Succeeded,
                    nextScheduled: nextScheduled,
                    lastFinished: now,
                    state: newState
            Severity: Minor
            Found in lib/models/work-item.js and 1 other location - About 40 mins to fix
            lib/models/work-item.js on lines 158..163

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 49.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            return taskGraphStore.updatePollerStatus(workItem.id, {
                    status: Constants.Task.States.Failed,
                    nextScheduled: nextScheduled,
                    lastFinished: now,
                    state: newState
            Severity: Minor
            Found in lib/models/work-item.js and 1 other location - About 40 mins to fix
            lib/models/work-item.js on lines 187..192

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 49.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                            if (!alertMessage) {
                    newState = workItem.state;
                } else if (!_.isEmpty(alertMessage)){
                    accessibleAlert(alertMessage, newState);
                }
            Severity: Minor
            Found in lib/models/work-item.js and 1 other location - About 35 mins to fix
            lib/models/work-item.js on lines 152..156

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                            if (!alertMessage) {
                    newState = workItem.state;
                } else if (! _.isEmpty(alertMessage)){
                    accessibleAlert(alertMessage, newState);
                }
            Severity: Minor
            Found in lib/models/work-item.js and 1 other location - About 35 mins to fix
            lib/models/work-item.js on lines 181..185

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status