Sign upLogin

RackHD/on-core

View on GitHub
Star
lib/workflow/stores/mongo.js

Summary

Maintainability
F
1 wk
Test Coverage

Function mongoStoreFactory has 663 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function mongoStoreFactory(waterline, Promise, Constants, Errors, assert, _) {
    var exports = {};

    exports.publishRecordByGraphId = function (graphId, event) {
        return waterline.graphobjects.needOneMongo(
Severity: Major
Found in lib/workflow/stores/mongo.js - About 3 days to fix

    File mongo.js has 676 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    // Copyright © 2015-2017 Dell Inc. or its subsidiaries.  All Rights Reserved.
'use strict';

module.exports = mongoStoreFactory;
mongoStoreFactory.$provide = 'TaskGraph.Stores.Mongo';
    Severity: Major
    Found in lib/workflow/stores/mongo.js - About 1 day to fix

      Function mongoStoreFactory has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
      Open

      function mongoStoreFactory(waterline, Promise, Constants, Errors, assert, _) {
    var exports = {};

    exports.publishRecordByGraphId = function (graphId, event) {
        return waterline.graphobjects.needOneMongo(
      Severity: Minor
      Found in lib/workflow/stores/mongo.js - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function updateUnreachableTasks has 68 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          exports.updateUnreachableTasks = function(data) {
        assert.object(data, 'data');
        assert.uuid(data.graphId, 'data.graphId');
        assert.uuid(data.taskId, 'data.taskId');
        assert.string(data.state, 'data.state');
      Severity: Major
      Found in lib/workflow/stores/mongo.js - About 2 hrs to fix

        Function checkoutTask has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            exports.checkoutTask = function(taskRunnerId, data) {
        assert.object(data, 'data');
        assert.uuid(data.graphId, 'data.graphId');
        assert.uuid(data.taskId, 'data.taskId');
        Severity: Minor
        Found in lib/workflow/stores/mongo.js - About 1 hr to fix

          Function updateDependentTasks has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              exports.updateDependentTasks = function(data) {
        assert.object(data, 'data');
        assert.uuid(data.graphId, 'data.graphId');
        assert.uuid(data.taskId, 'data.taskId');
        assert.string(data.state, 'data.state');
          Severity: Minor
          Found in lib/workflow/stores/mongo.js - About 1 hr to fix

            Function setTaskStateInGraph has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                exports.setTaskStateInGraph = function(data) {
        assert.uuid(data.taskId, 'data.taskId');
        assert.uuid(data.graphId, 'data.graphId');
        assert.string(data.state, 'data.state');
            Severity: Minor
            Found in lib/workflow/stores/mongo.js - About 1 hr to fix

              Function getTaskById has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  exports.getTaskById = function(data) {
        assert.object(data, 'data');
        assert.uuid(data.graphId, 'data.graphId');
        assert.uuid(data.taskId, 'data.taskId');
              Severity: Minor
              Found in lib/workflow/stores/mongo.js - About 1 hr to fix

                Function checkoutTimer has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    exports.checkoutTimer = function(leaseToken, criteria, leaseDuration) {
        var now = new Date();
        var query =  {
            $and: [
                criteria,
                Severity: Minor
                Found in lib/workflow/stores/mongo.js - About 1 hr to fix

                  Function mongoStoreFactory has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  function mongoStoreFactory(waterline, Promise, Constants, Errors, assert, _) {
                  Severity: Minor
                  Found in lib/workflow/stores/mongo.js - About 45 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        exports.persistGraphDefinition = function(definition) {
        assert.object(definition, 'definition');
        assert.string(definition.injectableName, 'definition.injectableName');

        var query = {
                    Severity: Major
                    Found in lib/workflow/stores/mongo.js and 1 other location - About 3 hrs to fix
                    lib/workflow/stores/mongo.js on lines 218..230

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 103.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        exports.persistTaskDefinition = function(definition) {
        assert.object(definition, 'definition');
        assert.string(definition.injectableName, 'definition.injectableName');

        var query = {
                    Severity: Major
                    Found in lib/workflow/stores/mongo.js and 1 other location - About 3 hrs to fix
                    lib/workflow/stores/mongo.js on lines 181..193

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 103.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        exports.destroyGraphDefinition = function(injectableName) {
        assert.string(injectableName, 'injectableName');

        var query = {
            injectableName: injectableName
                    Severity: Major
                    Found in lib/workflow/stores/mongo.js and 1 other location - About 1 hr to fix
                    lib/workflow/stores/mongo.js on lines 925..933

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 61.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        exports.deleteTaskByName = function(injectableName) {
        assert.string(injectableName, 'injectableName');

        var query = {
            injectableName: injectableName
                    Severity: Major
                    Found in lib/workflow/stores/mongo.js and 1 other location - About 1 hr to fix
                    lib/workflow/stores/mongo.js on lines 202..210

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 61.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            return waterline.graphobjects.find(query)
        .then(function(graphs) {
            return _.map(graphs, function(graph) {
                return graph.toJSON();
            });
                    Severity: Major
                    Found in lib/workflow/stores/mongo.js and 1 other location - About 1 hr to fix
                    lib/workflow/stores/mongo.js on lines 245..250

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 57.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            return waterline.graphdefinitions.find(query)
        .then(function(graphs) {
            return _.map(graphs, function(graph) {
                return graph.toJSON();
            });
                    Severity: Major
                    Found in lib/workflow/stores/mongo.js and 1 other location - About 1 hr to fix
                    lib/workflow/stores/mongo.js on lines 381..386

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 57.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            query.$or[0]['dependencies.'+data.taskId] = {
            $in: _.difference(Constants.Task.FinishedStates, [data.state])
        };
                    Severity: Major
                    Found in lib/workflow/stores/mongo.js and 1 other location - About 1 hr to fix
                    lib/workflow/stores/mongo.js on lines 712..714

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 56.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            query.$or[1]['dependencies.anyOf'+data.taskId] = {
            $in: _.difference(Constants.Task.FinishedStates, [data.state])
        };
                    Severity: Major
                    Found in lib/workflow/stores/mongo.js and 1 other location - About 1 hr to fix
                    lib/workflow/stores/mongo.js on lines 709..711

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 56.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status