RackHD/on-http

Function modifyUser has 27 lines of code (exceeds 25 allowed). Consider refactoring.

Open

var modifyUser = controller(function(req) {
    var name = req.swagger.params.name.value;
    var userObj = _.pick(req.swagger.params.body.value, ['password', 'role']);
    var configureUsersAllows = ['password', 'role'];
    var configureSelfAllows = ['password'];

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    return Promise.try(function() {
        if(!req.isAuthenticated || !req.isAuthenticated()) {
            throw new Errors.UnauthorizedError('Unauthorized');
        }
        return accountService.getUserByName(name);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            if( Object.keys(_.omit(req.swagger.params.body.value, configureUsersAllows)).length !== 0 ) {
                throw new Errors.BadRequestError('Bad Request');
            }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            if( Object.keys(_.omit(req.swagger.params.body.value, configureSelfAllows)).length !== 0 ) {
                throw new Errors.BadRequestError('Bad Request');
            }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

var removeUser = controller({success: 204}, function(req) {
    var name = req.swagger.params.name.value;
    return accountService.removeUserByName(name);
});

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

var getUser = controller(function(req) {
    var name = req.swagger.params.name.value;
    return accountService.getUserByName(name);
});

• Read up
  Read up