RackHD/on-http

View on GitHub
lib/api/redfish-1.0/event-service.js

Summary

Maintainability
D
1 day
Test Coverage

Function eventCallback has 95 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var eventCallback = function(events) {
    var clients;
    if(_.isArray(events.value)) {
        return _.forEach(events.value, function(event) {
            if(event.reading.sdrType === 'Threshold') {
Severity: Major
Found in lib/api/redfish-1.0/event-service.js - About 3 hrs to fix

    File event-service.js has 291 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    // Copyright 2016, EMC, Inc.
    
    'use strict';
    var urlParse = require('url-parse');
    var injector = require('../../../index.js').injector;
    Severity: Minor
    Found in lib/api/redfish-1.0/event-service.js - About 3 hrs to fix

      Function createSubscription has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      var createSubscription = controller(function(req, res) {
          var options = redfish.makeOptions(req, res);
          var event = req.swagger.params.payload.value;
          return redfish.validateSchema(event,
              'EventDestination.v1_1_1.json#/definitions/EventDestination'
      Severity: Minor
      Found in lib/api/redfish-1.0/event-service.js - About 1 hr to fix

        Identical blocks of code found in 3 locations. Consider refactoring.
        Open

                            return redfish.validateSchema(record, 'Event.v1_1_2.json#/definitions/EventRecord') //jshint ignore: line
                            .then(function(result) {
                                if(result.error) {
                                    throw new Error(result.error);
                                }
        Severity: Major
        Found in lib/api/redfish-1.0/event-service.js and 2 other locations - About 2 hrs to fix
        lib/api/redfish-1.0/event-service.js on lines 77..86
        lib/api/redfish-1.0/event-service.js on lines 135..144

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 78.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 3 locations. Consider refactoring.
        Open

                            return redfish.validateSchema(record, 'Event.v1_1_2.json#/definitions/EventRecord') //jshint ignore: line
                            .then(function(result) {
                                if(result.error) {
                                    throw new Error(result.error);
                                }
        Severity: Major
        Found in lib/api/redfish-1.0/event-service.js and 2 other locations - About 2 hrs to fix
        lib/api/redfish-1.0/event-service.js on lines 105..114
        lib/api/redfish-1.0/event-service.js on lines 135..144

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 78.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 3 locations. Consider refactoring.
        Open

                            return redfish.validateSchema(record, 'Event.v1_1_2.json#/definitions/EventRecord') //jshint ignore: line
                            .then(function(result) {
                                if(result.error) {
                                    throw new Error(result.error);
                                }
        Severity: Major
        Found in lib/api/redfish-1.0/event-service.js and 2 other locations - About 2 hrs to fix
        lib/api/redfish-1.0/event-service.js on lines 77..86
        lib/api/redfish-1.0/event-service.js on lines 105..114

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 78.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        module.exports = {
            eventServiceRoot: eventServiceRoot,
            createSubscription: createSubscription,
            getEventsCollection: getEventsCollection,
            getEvent: getEvent,
        Severity: Major
        Found in lib/api/redfish-1.0/event-service.js and 1 other location - About 1 hr to fix
        lib/api/2.0/pollers.js on lines 207..217

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status