RackHD/on-http

Function accountApiServiceFactory has 251 lines of code (exceeds 25 allowed). Consider refactoring.

Open

function accountApiServiceFactory(
    waterline,
    Errors,
    Logger,
    _,

File account-api-service.js has 279 lines of code (exceeds 250 allowed). Consider refactoring.

Open

// Copyright 2016, EMC, Inc.

'use strict';

var di = require('di'),

Function start has 40 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    AccountApiService.prototype.start = function() {
        var acl = this.acl;
        var self = this;
        var endpoints = configuration.get('httpEndpoints', []);
        var authEnabled = _(endpoints).filter(function(endpoint) {

Function modifyUserByName has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    AccountApiService.prototype.modifyUserByName = function(name, info) {
        var self = this;
        return Promise.try(function() {
            assert.string(name);
            return waterline.localusers.findOne({username: name});

Function accountApiServiceFactory has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

    waterline,
    Errors,
    Logger,
    _,
    Promise,

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        return Promise.try(function () {
            assert.string(name);
        })
        .then(function () {
            return waterline.roles.findOne({ role: name });

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        return Promise.try(function() {
            assert.string(name);
        })
        .then(function() {
            return waterline.localusers.findOne({username: name});

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            return Promise.props({
                id: user.id,
                username: user.username,
                role: user.role,
                privileges: self.aclMethod('_rolesParents', [user.role])

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            return Promise.props({
                id: user.id,
                username: user.username,
                role: user.role,
                privileges: self.aclMethod('_rolesParents', [user.role])

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

        return Promise.try(function() {
            assert.string(username);
            return waterline.localusers.findOne({username: username});
        })
        .then(function(user) {

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

        return Promise.try(function() {
            assert.string(name);
            return waterline.localusers.findOne({username: name});
        })
        .then(function(entry) {

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

        return Promise.try(function () {
            assert.string(name);
            return waterline.roles.findOne({ role: name });
        })
        .then(function (roleFound) {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            if(info.role && info.role !== entry.role) {
                return [entry, self.aclMethod('addUserRoles', entry.username, info.role)];
            }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            if(info.role && info.role !== entry.role) {
                return [entry, self.aclMethod('removeUserRoles', entry.username, entry.role)];
            }

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

        return Promise.try(function () {
            assert.string(name);
            return waterline.roles.findOne({ role: name });
        })
        .then(function (entry) {

• Read up
  Read up