Sign upLogin

RackHD/on-http

View on GitHub
Star
lib/services/http-service.js

Summary

Maintainability
F
4 days
Test Coverage

Function httpServiceFactory has 276 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function httpServiceFactory(
    eventsProtocol,
    configuration,
    lookupService,
    swagger,
Severity: Major
Found in lib/services/http-service.js - About 1 day to fix

    Function httpServiceFactory has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
    Open

    function httpServiceFactory(
    eventsProtocol,
    configuration,
    lookupService,
    swagger,
    Severity: Minor
    Found in lib/services/http-service.js - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File http-service.js has 341 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    // Copyright 2015, EMC, Inc.

'use strict';

var di = require('di');
    Severity: Minor
    Found in lib/services/http-service.js - About 4 hrs to fix

      Function httpEventMiddleware has 67 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function httpEventMiddleware(req, res, next) {
        req._startAt = process.hrtime();
        res.locals.ipAddress = remoteAddress(req);
        res.locals.scope = ['global'];
        res.locals.uuid = uuid.v4();
      Severity: Major
      Found in lib/services/http-service.js - About 2 hrs to fix

        Function _setup has 56 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            HttpService.prototype._setup =  function() {
        var app = this.app;
        var endpoint = this.endpoint;

        // CORS Support
        Severity: Major
        Found in lib/services/http-service.js - About 2 hrs to fix

          Function httpServiceFactory has 14 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              eventsProtocol,
    configuration,
    lookupService,
    swagger,
    Logger,
          Severity: Major
          Found in lib/services/http-service.js - About 1 hr to fix

            Function createHttpProxy has 41 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                function createHttpProxy(app, httpProxy){
        var sep = path.sep; //The platform-specific file separator. '\\' or '/'
        try {
            var localPath = httpProxy.localPath || sep,
                remotePath = httpProxy.remotePath || sep,
            Severity: Minor
            Found in lib/services/http-service.js - About 1 hr to fix

              Avoid too many return statements within this function.
              Open

                  return undefined;
              Severity: Major
              Found in lib/services/http-service.js - About 30 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                                    logger.error(
                        'http: ' + req.method +
                        ' ' + res.statusCode +
                        ' ' + ms.toFixed(3) +
                        ' - ' + res.locals.uuid +
                Severity: Major
                Found in lib/services/http-service.js and 1 other location - About 2 hrs to fix
                lib/services/http-service.js on lines 328..335

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 76.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            logger.debug(
                'http: ' + req.method +
                ' ' + res.statusCode +
                ' ' + ms.toFixed(3) +
                ' - ' + res.locals.uuid +
                Severity: Major
                Found in lib/services/http-service.js and 1 other location - About 2 hrs to fix
                lib/services/http-service.js on lines 339..346

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 76.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status