Sign upLogin

RackHD/on-http

View on GitHub
Star
lib/services/rest-api-service.js

Summary

Maintainability
D
2 days
Test Coverage

Function restFactory has 217 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function restFactory(
    Serializable,
    Promise,
    _,
    assert,
Severity: Major
Found in lib/services/rest-api-service.js - About 1 day to fix

    Function restFactory has a Cognitive Complexity of 54 (exceeds 5 allowed). Consider refactoring.
    Open

    function restFactory(
    Serializable,
    Promise,
    _,
    assert,
    Severity: Minor
    Found in lib/services/rest-api-service.js - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function handleError has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        rest.handleError = function () {
        return function handleErrorMiddleware(err, req, res, next) {
            // TODO - implement custom error type serializers
            if (err instanceof Error || err instanceof ErrorEvent) {
                var message = err.message || http.STATUS_CODES[err.status] || 'Unspecified Error';
    Severity: Minor
    Found in lib/services/rest-api-service.js - About 1 hr to fix

      Function restFactory has 9 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          Serializable,
    Promise,
    _,
    assert,
    util,
      Severity: Major
      Found in lib/services/rest-api-service.js - About 1 hr to fix

        Function rest has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function rest(callback, options) {
        assert.func(callback, 'callback function is required');
        assert.optionalObject(options, 'options should be an optional object');

        options = options || {};
        Severity: Minor
        Found in lib/services/rest-api-service.js - About 1 hr to fix

          Function handleErrorMiddleware has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  return function handleErrorMiddleware(err, req, res, next) {
            // TODO - implement custom error type serializers
            if (err instanceof Error || err instanceof ErrorEvent) {
                var message = err.message || http.STATUS_CODES[err.status] || 'Unspecified Error';
                logger.error(message, {
          Severity: Minor
          Found in lib/services/rest-api-service.js - About 1 hr to fix

            There are no issues that match your filters.

            Category
            Status