Sign upLogin

RackHD/on-taskgraph

View on GitHub
Star

Showing 247 of 247 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

var workflowsGetTasksByName = function(call) {
    return Promise.try(function() {
        return workflowApiService.getWorkflowsTasksByName(call.request.injectableName);
    });
};
Severity: Minor
Found in api/rpc/workflowTasks.js and 1 other location - About 40 mins to fix
api/rpc/workflowGraphs.js on lines 14..18

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function handleExecResult has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    var handleExecResult = function(_task, _done, error, stdout, stderr) {
Severity: Minor
Found in data/templates/bootstrap.js - About 35 mins to fix

    Function mark_on_disk has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def mark_on_disk(disk_name, log, flag, back_skip, mark_files):
    Severity: Minor
    Found in data/templates/secure_erase.py - About 35 mins to fix

      Function schemaApiServiceFactory has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          configuration,
    Logger,
    Promise,
    _,
    nodeFs
      Severity: Minor
      Found in lib/services/schema-api-service.js - About 35 mins to fix

        Function taskApiServiceFactory has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        function taskApiServiceFactory(
    taskProtocol,
    waterline,
    Errors,
    util,
        Severity: Minor
        Found in lib/services/task-api-service.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function __sg_requests_parser has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def __sg_requests_parser(self, drive):
        """
        Secure erase job progress parser for sg_format and sg_sanitize tools.
        :param drive: drive name
        :return: a float digital of percentage
        Severity: Minor
        Found in data/templates/secure_erase.py - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getSataNameStr has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        function getSataNameStr(sataDrive) {
    var output = execSync(cmdSataRawInfo + ' /dev/' + sataDrive);
    /*  output data like below:
     *  $ sudo hdparm --Istdout /dev/sda
     *  dev/sda:
        Severity: Minor
        Found in data/templates/get_driveid.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function __get_hdparm_duration has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def __get_hdparm_duration(self, log):
        """
        Get hdparm required secure erase time.
        :param log: a file object of secure erase log
        :return: required secure erase time indicated by hdparm tool
        Severity: Minor
        Found in data/templates/secure_erase.py - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            log.write(COMMAND_LOG_MARKER + "[" + " ".join(cmd) + "] output:\n")
        Severity: Minor
        Found in data/templates/secure_erase.py and 1 other location - About 35 mins to fix
        data/templates/secure_erase.py on lines 391..391

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 33.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            log.write(COMMAND_LOG_MARKER + "[" + " ".join(cmd) + "] output:\n")
        Severity: Minor
        Found in data/templates/secure_erase.py and 1 other location - About 35 mins to fix
        data/templates/secure_erase.py on lines 413..413

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 33.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        module.exports = {
    friendlyName: 'Dell Racadm Get Config Catalog Graph',
    injectableName: 'Graph.Dell.Racadm.GetConfigCatalog',
    option: {},
    tasks: [
        Severity: Minor
        Found in lib/graphs/dell-racadm-get-config-catalog-graph.js and 2 other locations - About 35 mins to fix
        lib/graphs/emc-redfish-discovery-graph.js on lines 5..15
        lib/graphs/ucs-catalog-graph.js on lines 5..15

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            tasks: [
        {
            label: 'delete-volume',
            taskName: 'Task.Delete.Volume'
        },
        Severity: Minor
        Found in lib/graphs/delete-volume-graph.js and 2 other locations - About 35 mins to fix
        lib/graphs/add-hotspare-graph.js on lines 16..30
        lib/graphs/add-volume-graph.js on lines 17..31

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        module.exports = {
    friendlyName: 'Ucs Catalog',
    injectableName: 'Graph.Ucs.Catalog',
    options: {},
    tasks: [
        Severity: Minor
        Found in lib/graphs/ucs-catalog-graph.js and 2 other locations - About 35 mins to fix
        lib/graphs/dell-racadm-get-config-catalog-graph.js on lines 5..15
        lib/graphs/emc-redfish-discovery-graph.js on lines 5..15

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            tasks: [
        {
            label: 'add-volume',
            taskName: 'Task.Add.Volume'
        },
        Severity: Minor
        Found in lib/graphs/add-volume-graph.js and 2 other locations - About 35 mins to fix
        lib/graphs/add-hotspare-graph.js on lines 16..30
        lib/graphs/delete-volume-graph.js on lines 14..27

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        module.exports = {
    friendlyName: 'EMC Redfish Catalog',
    injectableName: 'Graph.Emc.Redfish.Catalog',
    options: {},
    tasks: [
        Severity: Minor
        Found in lib/graphs/emc-redfish-discovery-graph.js and 2 other locations - About 35 mins to fix
        lib/graphs/dell-racadm-get-config-catalog-graph.js on lines 5..15
        lib/graphs/ucs-catalog-graph.js on lines 5..15

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            tasks: [
        {
            label: 'add-hotspare',
            taskName: 'Task.Add.Hotspare'
        },
        Severity: Minor
        Found in lib/graphs/add-hotspare-graph.js and 2 other locations - About 35 mins to fix
        lib/graphs/add-volume-graph.js on lines 17..31
        lib/graphs/delete-volume-graph.js on lines 14..27

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Avoid too many return statements within this function.
        Open

                return undefined;
        Severity: Major
        Found in app.js - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              try:
        cmd = "Cli -p2 -c 'show running-config'"
        data['running-config'] = subprocess.check_output(cmd, shell=True)
    except:
          Severity: Minor
          Found in data/templates/arista-catalog-config.py and 1 other location - About 30 mins to fix
          data/templates/arista-catalog-config.py on lines 7..10

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 32.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              try:
        host = json.loads(clid('show snmp host'))
        data['host'] = host
    except:
          Severity: Major
          Found in data/templates/cisco-catalog-snmp-settings.py and 3 other locations - About 30 mins to fix
          data/templates/cisco-catalog-snmp-settings.py on lines 10..13
          data/templates/cisco-catalog-snmp-settings.py on lines 16..19
          data/templates/cisco-catalog-snmp-settings.py on lines 28..31

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 32.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              try:
        all = json.loads(clid('show snmp'))
        data['snmp'] = all
    except:
          Severity: Major
          Found in data/templates/cisco-catalog-snmp-settings.py and 3 other locations - About 30 mins to fix
          data/templates/cisco-catalog-snmp-settings.py on lines 16..19
          data/templates/cisco-catalog-snmp-settings.py on lines 22..25
          data/templates/cisco-catalog-snmp-settings.py on lines 28..31

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 32.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Severity
          Category
          Status
          Source
          Language