Sign upLogin

RackHD/on-taskgraph

View on GitHub
Star

Showing 247 of 247 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        return Rx.Observable.interval(self.pollInterval)
        .takeWhile(self.isRunning.bind(self))
        .map(self.findUnevaluatedTasks.bind(self, self.domain))
        .mergeLossy(self.concurrencyMaximums.findUnevaluatedTasks)
Severity: Major
Found in lib/task-scheduler.js and 1 other location - About 1 hr to fix
lib/completed-task-poller.js on lines 92..95

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 67.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        Rx.Observable.interval(self.pollInterval)
        .takeWhile(self.isRunning.bind(self))
        .map(self.processCompletedTasks.bind(self, self.completedTaskBatchSize))
        .mergeLossy(self.concurrentCounter)
Severity: Major
Found in lib/completed-task-poller.js and 1 other location - About 1 hr to fix
lib/task-scheduler.js on lines 649..652

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 67.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function templatesGetByName has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    TemplateApiService.prototype.templatesGetByName = function(req, res) {
        return Promise.resolve()
            .then(function() {
                var nodeId = req.query.nodeId;
                var macs = req.query.macs;
Severity: Minor
Found in lib/services/templates-api-service.js - About 1 hr to fix

    Function handlePotentialFinishedGraph has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        CompletedTaskPoller.prototype.handlePotentialFinishedGraph = function(data) {
        var self = this;
        assert.object(data, 'data');
        assert.string(data.state, 'data.state');
    Severity: Minor
    Found in lib/completed-task-poller.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              {
            "label": "disable-redfish-alerts",
            "taskDefinition": {
                "friendlyName": "Disable Redfish Alerting",
                "injectableName": "Task.Dell.Disable.Redfish.Alert",
      Severity: Major
      Found in lib/graphs/dell-configure-redfish-alerting-graph.js and 1 other location - About 1 hr to fix
      lib/graphs/dell-configure-redfish-alerting-graph.js on lines 28..44

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              {
            "label": "enable-redfish-alerts",
            "taskDefinition": {
                "friendlyName": "Enable Redfish Alerting",
                "injectableName": "Task.Dell.Enable.Redfish.Alert",
      Severity: Major
      Found in lib/graphs/dell-configure-redfish-alerting-graph.js and 1 other location - About 1 hr to fix
      lib/graphs/dell-configure-redfish-alerting-graph.js on lines 45..61

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function getProfiles has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          ProfileApiService.prototype.getProfiles = function(req, query, res) {
        var self = this;
        var ipAddress = res.locals.ipAddress;
        return self.getMacAddressInRequest(query, ipAddress)
        .then(function(macAddress) {
      Severity: Minor
      Found in lib/services/profile-api-service.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            var lines = pathList.split('\n').map(function(line) {
        var split = line.split(/\s+/);
        return [split[8],split[10]].join('->');
    });
        Severity: Major
        Found in data/templates/get_driveid.js and 1 other location - About 1 hr to fix
        data/templates/get_driveid.js on lines 81..84

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 65.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            var lines = idList.split('\n').map(function(line) {
        var split = line.split(/\s+/);
        return [split[8],split[10]].join('->');
    });
        Severity: Major
        Found in data/templates/get_driveid.js and 1 other location - About 1 hr to fix
        data/templates/get_driveid.js on lines 166..169

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 65.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function swaggerController has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function swaggerController(options, callback) {
        if (typeof options === 'function') {
            callback = options;
            options = {};
        }
        Severity: Minor
        Found in lib/services/swagger-api-service.js - About 1 hr to fix

          Function getTasks has 37 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function getTasks(timeout) {
    http.request({
        hostname: server,
        port: port,
        path: tasksPath,
          Severity: Minor
          Found in data/templates/bootstrap.js - About 1 hr to fix

            Function validate has 36 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                SchemaApiService.prototype.validate = function(obj, schemaName)  {
        return Promise.resolve().then(function() {
            var basename;

            // If a schemaName is specified, then validate against that
            Severity: Minor
            Found in lib/services/schema-api-service.js - About 1 hr to fix

              Function parse_snmp_host has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

              def parse_snmp_host(snmpString):
    i = 0
    parsedString = ""

    # Replace multiple spaces with a new line
              Severity: Minor
              Found in data/templates/arista-catalog-snmp-settings.py - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function taskRunnerFactory has 11 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  Logger,
    Promise,
    graphProgressService,
    Constants,
    assert,
              Severity: Major
              Found in lib/task-runner.js - About 1 hr to fix

                Function failGraph has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    TaskScheduler.prototype.failGraph = function(data, graphState) {
        var self = this;
        var graphToBePublished;
        return Rx.Observable.just(data.graphId)
        .flatMap(store.getActiveGraphById)
                Severity: Minor
                Found in lib/task-scheduler.js - About 1 hr to fix

                  Function getSwitchDiscoveryConfiguration has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      ProfileApiService.prototype.getSwitchDiscoveryConfiguration = function(node, vendor) {
        var configuration = {
            name: 'Graph.SKU.Switch.Discovery.Active',
            options: {
                defaults: {
                  Severity: Minor
                  Found in lib/services/profile-api-service.js - About 1 hr to fix

                    Function run has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    function run(done) {
    var wwidData, vdData, scsiData;
    try {
        exec(cmdDriveWwid, options, function (err0, stdout0) {
            if (err0) {
                    Severity: Minor
                    Found in data/templates/get_driveid.js - About 1 hr to fix

                      Function load has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          Loader.prototype.load = function() {
        var self = this;

        return Promise.all([
            store.getTaskDefinitions(),
                      Severity: Minor
                      Found in lib/loader.js - About 1 hr to fix

                        Function start has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            function start() {
        var app = require('express')();
        var http = require('http');
        var swaggerTools = require('swagger-tools');
        var rewriter = require('express-urlrewrite');
                        Severity: Minor
                        Found in app.js - About 1 hr to fix

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  if (timeout) {
            console.log("Sleeping " + timeout + " for Task Execution...");

            setTimeout(function () {
                getTasks(timeout);
                          Severity: Major
                          Found in data/templates/bootstrap.js and 1 other location - About 1 hr to fix
                          data/templates/bootstrap.js on lines 201..210

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 61.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Severity
                          Category
                          Status
                          Source
                          Language