Sign upLogin

RackHD/on-web-ui

View on GitHub
Star
src/app/management-center/skus/sku.component.ts

Summary

Maintainability
C
1 day
Test Coverage

Function createSku has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  createSku(): void {
    let jsonData = {};
    this.skuForm.getRawValue();
    let value = this.skuForm.value;
    // data transform
Severity: Minor
Found in src/app/management-center/skus/sku.component.ts - About 1 hr to fix

    Function createSku has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

      createSku(): void {
    let jsonData = {};
    this.skuForm.getRawValue();
    let value = this.skuForm.value;
    // data transform
    Severity: Minor
    Found in src/app/management-center/skus/sku.component.ts - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      deleteSel(): void {
    let list = [];
    _.forEach(this.selectedSkus, sku => {
      list.push(sku.id);
    });
    Severity: Major
    Found in src/app/management-center/skus/sku.component.ts and 2 other locations - About 3 hrs to fix
    src/app/management-center/obms/obm.component.ts on lines 221..231
    src/app/management-center/pollers/pollers.component.ts on lines 228..238

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 96.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

      getAllSkus(): void {
    this.skusService.getAll()
      .subscribe( data => {
        this.skuStore = data;
        this.allSkus = data;
    Severity: Major
    Found in src/app/management-center/skus/sku.component.ts and 7 other locations - About 1 hr to fix
    src/app/management-center/catalogs/catalogs.component.ts on lines 46..53
    src/app/management-center/files/files.component.ts on lines 57..64
    src/app/management-center/obms/obm.component.ts on lines 98..105
    src/app/management-center/profiles/profiles.component.ts on lines 48..55
    src/app/management-center/templates/templates.component.ts on lines 47..54
    src/app/management-center/workflows/workflows.component.ts on lines 60..67
    src/app/workflow-center/active-workflow/active-workflow.component.ts on lines 73..80

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 73.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 5 locations. Consider refactoring.
    Open

      onAction(action){
    switch(action) {
      case 'Refresh':
        this.refresh();
        break;
    Severity: Major
    Found in src/app/management-center/skus/sku.component.ts and 4 other locations - About 1 hr to fix
    src/app/management-center/files/files.component.ts on lines 130..142
    src/app/management-center/nodes/nodes.component.ts on lines 196..208
    src/app/management-center/pollers/pollers.component.ts on lines 90..102
    src/app/management-center/workflows/workflows.component.ts on lines 131..143

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 59.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

      onConfirm(value) {
    switch(value) {
      case 'reject':
        this.isDelete = false;
        break;
    Severity: Major
    Found in src/app/management-center/skus/sku.component.ts and 5 other locations - About 55 mins to fix
    src/app/management-center/nodes/nodes.component.ts on lines 185..194
    src/app/management-center/obms/obm.component.ts on lines 72..81
    src/app/management-center/pollers/pollers.component.ts on lines 79..88
    src/app/workflow-center/active-workflow/active-workflow.component.ts on lines 143..152
    src/app/workflow-center/history-workflow/history-workflow.component.ts on lines 163..172

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status