Sign upLogin

RadarParlamentar-MES2017-1/radar

View on GitHub
Star
radar_parlamentar/exportadores/exportador_csv_r.py

Summary

Maintainability
B
5 hrs
Test Coverage

Cyclomatic complexity is too high in method retrieve_votacoes. (10)
Open

    def retrieve_votacoes(self):
        try:
            casa = models.CasaLegislativa.objects.get(nome_curto='cdep')
        except:
            casa = None
Severity: Minor
Found in radar_parlamentar/exportadores/exportador_csv_r.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Cyclomatic complexity is too high in method voto. (6)
Open

    def voto(self, opcao):
        if opcao == models.SIM:
            return 1
        elif opcao == models.NAO:
            return -1
Severity: Minor
Found in radar_parlamentar/exportadores/exportador_csv_r.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Avoid too many return statements within this function.
Open

            return 0
Severity: Major
Found in radar_parlamentar/exportadores/exportador_csv_r.py - About 30 mins to fix

    Function retrieve_votacoes has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def retrieve_votacoes(self):
        try:
            casa = models.CasaLegislativa.objects.get(nome_curto='cdep')
        except:
            casa = None
    Severity: Minor
    Found in radar_parlamentar/exportadores/exportador_csv_r.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function transform_data has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def transform_data(self):
        self.csv_rows.append(LABELS)
        for votacao in self.votacoes:
            votos = votacao.votos()
            for voto in votos:
    Severity: Minor
    Found in radar_parlamentar/exportadores/exportador_csv_r.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function voto has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def voto(self, opcao):
        if opcao == models.SIM:
            return 1
        elif opcao == models.NAO:
            return -1
    Severity: Minor
    Found in radar_parlamentar/exportadores/exportador_csv_r.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        def write_csv(self):
        filepath = os.path.join(MODULE_DIR, 'saida', CSV_FILE)
        with open(filepath, 'w') as f:
            writer = csv.writer(f, delimiter=',')
            writer.writerows(self.csv_rows)
    Severity: Major
    Found in radar_parlamentar/exportadores/exportador_csv_r.py and 1 other location - About 2 hrs to fix
    radar_parlamentar/exportadores/exportador_csv.py on lines 116..120

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 58.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            if self.ini is None and self.fim is not None:
            self.votacoes = models.Votacao.objects.filter(
                proposicao__casa_legislativa=casa
            ).filter(data__lte=self.fim).order_by('data')
    Severity: Minor
    Found in radar_parlamentar/exportadores/exportador_csv_r.py and 1 other location - About 45 mins to fix
    radar_parlamentar/exportadores/exportador_csv_r.py on lines 76..79

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 35.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            if self.ini is not None and self.fim is None:
            self.votacoes = models.Votacao.objects.filter(
                proposicao__casa_legislativa=casa
            ).filter(data__gte=self.ini).order_by('data')
    Severity: Minor
    Found in radar_parlamentar/exportadores/exportador_csv_r.py and 1 other location - About 45 mins to fix
    radar_parlamentar/exportadores/exportador_csv_r.py on lines 72..75

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 35.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Do not use bare 'except'
    Open

                    except:
    Severity: Minor
    Found in radar_parlamentar/exportadores/exportador_csv_r.py by pep8

    When catching exceptions, mention specific exceptions when possible.

    Okay: except Exception:
Okay: except BaseException:
E722: except:

    Do not use bare 'except'
    Open

            except:
    Severity: Minor
    Found in radar_parlamentar/exportadores/exportador_csv_r.py by pep8

    When catching exceptions, mention specific exceptions when possible.

    Okay: except Exception:
Okay: except BaseException:
E722: except:

    There are no issues that match your filters.

    Category
    Status