Sign upLogin

RadarParlamentar-MES2017-1/radar

View on GitHub
Star
radar_parlamentar/importadores/sen.py

Summary

Maintainability
C
1 day
Test Coverage

File sen.py has 289 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# !/usr/bin/python
# coding=utf8

# Copyright (C) 2012, Leonardo Leite
#
Severity: Minor
Found in radar_parlamentar/importadores/sen.py - About 2 hrs to fix

    ImportadorVotacoesSenado has 24 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class ImportadorVotacoesSenado:

    """Salva os dados dos arquivos XML do senado no banco de dados"""

    def __init__(self):
    Severity: Minor
    Found in radar_parlamentar/importadores/sen.py - About 2 hrs to fix

      Cyclomatic complexity is too high in method _save_votacao_in_db. (8)
      Open

          def _save_votacao_in_db(self, xml_file):

        tree = self._read_xml(xml_file)

        votacoes = []
      Severity: Minor
      Found in radar_parlamentar/importadores/sen.py by radon

      Cyclomatic Complexity

      Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

      Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

      Construct Effect on CC Reasoning
      if +1 An if statement is a single decision.
      elif +1 The elif statement adds another decision.
      else +0 The else statement does not cause a new decision. The decision is at the if.
      for +1 There is a decision at the start of the loop.
      while +1 There is a decision at the while statement.
      except +1 Each except branch adds a new conditional path of execution.
      finally +0 The finally block is unconditionally executed.
      with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
      assert +1 The assert statement internally roughly equals a conditional statement.
      Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
      Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

      Source: http://radon.readthedocs.org/en/latest/intro.html

      Cyclomatic complexity is too high in method _voto_senado_to_model. (7)
      Open

          def _voto_senado_to_model(self, voto):
        """Interpreta voto como tá no XML e responde em adequação a modelagem
        em models.py"""

        DESCULPAS = ['MIS', 'MERC', 'P-NRV', 'REP',
      Severity: Minor
      Found in radar_parlamentar/importadores/sen.py by radon

      Cyclomatic Complexity

      Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

      Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

      Construct Effect on CC Reasoning
      if +1 An if statement is a single decision.
      elif +1 The elif statement adds another decision.
      else +0 The else statement does not cause a new decision. The decision is at the if.
      for +1 There is a decision at the start of the loop.
      while +1 There is a decision at the while statement.
      except +1 Each except branch adds a new conditional path of execution.
      finally +0 The finally block is unconditionally executed.
      with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
      assert +1 The assert statement internally roughly equals a conditional statement.
      Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
      Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

      Source: http://radon.readthedocs.org/en/latest/intro.html

      Function _save_votacao_in_db has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          def _save_votacao_in_db(self, xml_file):

        tree = self._read_xml(xml_file)

        votacoes = []
      Severity: Minor
      Found in radar_parlamentar/importadores/sen.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _voto_senado_to_model has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def _voto_senado_to_model(self, voto):
        """Interpreta voto como tá no XML e responde em adequação a modelagem
        em models.py"""

        DESCULPAS = ['MIS', 'MERC', 'P-NRV', 'REP',
      Severity: Minor
      Found in radar_parlamentar/importadores/sen.py - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

                  return models.ABSTENCAO
      Severity: Major
      Found in radar_parlamentar/importadores/sen.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return models.ABSTENCAO
        Severity: Major
        Found in radar_parlamentar/importadores/sen.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return models.ABSTENCAO
          Severity: Major
          Found in radar_parlamentar/importadores/sen.py - About 30 mins to fix

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                def _init_parlamentares(self):
        """retorna dicionário
           (nome_parlamentar, nome_partido, localidade) -> Parlamentar"""
        parlamentares = {}
        for p in models.Parlamentar.objects.filter(
            Severity: Major
            Found in radar_parlamentar/importadores/sen.py and 3 other locations - About 2 hrs to fix
            radar_parlamentar/importadores/cdep.py on lines 311..317
            radar_parlamentar/importadores/cdep.py on lines 332..338
            radar_parlamentar/importadores/cmsp.py on lines 85..91

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 54.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if partido is None:
            logger.warning('Não achou o partido %s' % nome_partido)
            partido = models.Partido.get_sem_partido()
            Severity: Minor
            Found in radar_parlamentar/importadores/sen.py and 1 other location - About 50 mins to fix
            radar_parlamentar/importadores/cmsp.py on lines 147..149

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 36.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Invalid escape sequence '\d'
            Open

                    DATA_REGEX = '(\d{4})-(\d{2})-(\d{2})'
            Severity: Minor
            Found in radar_parlamentar/importadores/sen.py by pep8

            Invalid escape sequences are deprecated in Python 3.6.

            Okay: regex = r'\.png$'
W605: regex = '\.png$'

            Invalid escape sequence '\d'
            Open

                    DATA_REGEX = '(\d{4})-(\d{2})-(\d{2})'
            Severity: Minor
            Found in radar_parlamentar/importadores/sen.py by pep8

            Invalid escape sequences are deprecated in Python 3.6.

            Okay: regex = r'\.png$'
W605: regex = '\.png$'

            Invalid escape sequence '\d'
            Open

                    DATA_REGEX = '(\d{4})-(\d{2})-(\d{2})'
            Severity: Minor
            Found in radar_parlamentar/importadores/sen.py by pep8

            Invalid escape sequences are deprecated in Python 3.6.

            Okay: regex = r'\.png$'
W605: regex = '\.png$'

            There are no issues that match your filters.

            Category
            Status