Sign upLogin

Rafalsky/HomeFinance

View on GitHub
Star
backend/controllers/SignInController.php

Summary

Maintainability
D
3 days
Test Coverage

actionProfile accesses the super-global variable $_POST.
Open

    public function actionProfile()
    {
        $model = \Yii::$app->user->identity->userProfile;
        if ($model->load($_POST) && $model->save()) {
            \Yii::$app->session->setFlash('alert', [
Severity: Minor
Found in backend/controllers/SignInController.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

actionAccount accesses the super-global variable $_POST.
Open

    public function actionAccount()
    {
        $user = \Yii::$app->user->identity;
        $model = new AccountForm();
        $model->username = $user->username;
Severity: Minor
Found in backend/controllers/SignInController.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

The method actionLogin uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            return $this->render('login', [
                'model' => $model
            ]);
        }
Severity: Minor
Found in backend/controllers/SignInController.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Identical blocks of code found in 2 locations. Consider refactoring.
Open

<?php

/*
 *  This file is part of the HomeFinanceV2 project.
 *
Severity: Major
Found in backend/controllers/SignInController.php and 1 other location - About 3 days to fix
wallet/controllers/SignInController.php on lines 1..114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 576.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status