Rafalsky/HomeFinance

View on GitHub
common/migrations/db/m160624_232040_add_warranty_table.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid using short method names like m160624_232040_add_warranty_table::up(). The configured minimum method name length is 3.
Open

    public function up()
    {
        $tableOptions = null;
        if ($this->db->driverName === 'mysql') {
            $tableOptions = 'CHARACTER SET utf8 COLLATE utf8_unicode_ci ENGINE=InnoDB';

ShortMethodName

Since: 0.2

Detects when very short method names are used.

Example

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Source https://phpmd.org/rules/naming.html#shortmethodname

The class m160624_232040_add_warranty_table is not named in CamelCase.
Open

class m160624_232040_add_warranty_table extends Migration
{
    public function up()
    {
        $tableOptions = null;

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

There are no issues that match your filters.

Category
Status