Sign upLogin

Rafalsky/HomeFinance

View on GitHub
Star
common/migrations/rbac/m150625_215624_init_permissions.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid using short method names like m150625_215624_init_permissions::up(). The configured minimum method name length is 3.
Open

    public function up()
    {
        $managerRole = $this->auth->getRole(\common\models\User::ROLE_MANAGER);

        $loginToBackend = $this->auth->createPermission('loginToBackend');
Severity: Minor
Found in common/migrations/rbac/m150625_215624_init_permissions.php by phpmd

ShortMethodName

Since: 0.2

Detects when very short method names are used.

Example

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Source https://phpmd.org/rules/naming.html#shortmethodname

The class m150625_215624_init_permissions is not named in CamelCase.
Open

class m150625_215624_init_permissions extends Migration
{
    public function up()
    {
        $managerRole = $this->auth->getRole(\common\models\User::ROLE_MANAGER);
Severity: Minor
Found in common/migrations/rbac/m150625_215624_init_permissions.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

There are no issues that match your filters.

Category
Status