Rafalsky/HomeFinance

View on GitHub
common/migrations/rbac/m151223_074604_edit_own_model.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid excessively long variable names like $editOwnModelPermission. Keep variable name length under 20.
Open

        $editOwnModelPermission = $this->auth->createPermission('editOwnModel');

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid using short method names like m151223_074604_edit_own_model::up(). The configured minimum method name length is 3.
Open

    public function up()
    {
        $rule = new OwnModelRule();
        $this->auth->add($rule);

ShortMethodName

Since: 0.2

Detects when very short method names are used.

Example

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Source https://phpmd.org/rules/naming.html#shortmethodname

The class m151223_074604_edit_own_model is not named in CamelCase.
Open

class m151223_074604_edit_own_model extends Migration
{
    public function up()
    {
        $rule = new OwnModelRule();

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

There are no issues that match your filters.

Category
Status