Sign upLogin

Rafalsky/HomeFinance

View on GitHub
Star
common/models/User.php

Summary

Maintainability
A
3 hrs
Test Coverage

The class User has 15 public methods. Consider refactoring User to keep number of public methods under 10.
Open

class User extends ActiveRecord implements IdentityInterface
{
    const STATUS_NOT_ACTIVE = 1;
    const STATUS_ACTIVE = 2;
    const STATUS_DELETED = 3;
Severity: Minor
Found in common/models/User.php by phpmd

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

User has 21 functions (exceeds 20 allowed). Consider refactoring.
Open

class User extends ActiveRecord implements IdentityInterface
{
    const STATUS_NOT_ACTIVE = 1;
    const STATUS_ACTIVE = 2;
    const STATUS_DELETED = 3;
Severity: Minor
Found in common/models/User.php - About 2 hrs to fix

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

        public function attributeLabels()
    {
        return [
            'username' => \Yii::t('common', 'Username'),
            'email' => \Yii::t('common', 'E-mail'),
    Severity: Major
    Found in common/models/User.php and 4 other locations - About 1 hr to fix
    common/models/UserProfile.php on lines 77..88
    common/models/UserToken.php on lines 80..91
    common/models/base/ReceiptProduct.php on lines 56..67
    common/models/base/Wallet.php on lines 59..70

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 113.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid variables with short names like $id. Configured minimum length is 3.
    Open

        public static function findIdentity($id)
    Severity: Minor
    Found in common/models/User.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    There are no issues that match your filters.

    Category
    Status