Sign upLogin

RailsEventStore/rails_event_store

View on GitHub
Star
ruby_event_store-active_record/lib/ruby_event_store/active_record/event_repository_reader.rb

Summary

Maintainability
D
1 day
Test Coverage

Method read_scope has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
Open

      def read_scope(spec)
        if spec.stream.global?
          stream = @event_klass
          stream = stream.where(event_id: spec.with_ids) if spec.with_ids?
          stream = stream.where(event_type: spec.with_types) if spec.with_types?
Severity: Minor
Found in ruby_event_store-active_record/lib/ruby_event_store/active_record/event_repository_reader.rb - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class EventRepositoryReader has 29 methods (exceeds 20 allowed). Consider refactoring.
Open

    class EventRepositoryReader
      def initialize(event_klass, stream_klass, serializer)
        @event_klass = event_klass
        @stream_klass = stream_klass
        @serializer = serializer
Severity: Minor
Found in ruby_event_store-active_record/lib/ruby_event_store/active_record/event_repository_reader.rb - About 3 hrs to fix

    Method read has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

          def read(spec)
        stream = read_scope(spec)
        if spec.batched?
          spec.time_sort_by ? offset_limit_batch_reader(spec, stream) : monotonic_id_batch_reader(spec, stream)
        elsif spec.first?
    Severity: Minor
    Found in ruby_event_store-active_record/lib/ruby_event_store/active_record/event_repository_reader.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method read_scope has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def read_scope(spec)
        if spec.stream.global?
          stream = @event_klass
          stream = stream.where(event_id: spec.with_ids) if spec.with_ids?
          stream = stream.where(event_type: spec.with_types) if spec.with_types?
    Severity: Minor
    Found in ruby_event_store-active_record/lib/ruby_event_store/active_record/event_repository_reader.rb - About 1 hr to fix

      Method monotonic_id_batch_reader has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def monotonic_id_batch_reader(spec, stream)
        batch_reader = ->(offset_id, limit) do
          search_in = spec.stream.global? ? @event_klass.table_name : @stream_klass.table_name
          records =
            if offset_id.nil?
      Severity: Minor
      Found in ruby_event_store-active_record/lib/ruby_event_store/active_record/event_repository_reader.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status