Sign upLogin

RasaHQ/rasa

View on GitHub
Star
rasa/core/actions/forms.py

Summary

Maintainability
C
1 day
Test Coverage
A
91%

File forms.py has 588 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import copy
from typing import Text, List, Optional, Union, Any, Dict, Set
import itertools
import logging
import structlog
Severity: Major
Found in rasa/core/actions/forms.py - About 1 day to fix

    Function _create_unique_entity_mappings has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def _create_unique_entity_mappings(self, domain: Domain) -> Set[Text]:
        """Finds mappings of type `from_entity` that uniquely set a slot.

        For example in the following form:
        some_form:
    Severity: Minor
    Found in rasa/core/actions/forms.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function from_entity has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def from_entity(
    Severity: Minor
    Found in rasa/core/actions/forms.py - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status