RasaHQ/rasa_core

View on GitHub
rasa/core/processor.py

Summary

Maintainability
C
1 day
Test Coverage

File processor.py has 374 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import json
import logging
from types import LambdaType
from typing import Any, Dict, List, Optional, Text, Tuple

Severity: Minor
Found in rasa/core/processor.py - About 5 hrs to fix

    Function _warn_about_new_slots has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        def _warn_about_new_slots(self, tracker, action_name, events):
            # these are the events from that action we have seen during training
    
            if action_name not in self.policy_ensemble.action_fingerprints:
                return
    Severity: Minor
    Found in rasa/core/processor.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __init__ has 9 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __init__(self,
    Severity: Major
    Found in rasa/core/processor.py - About 1 hr to fix

      Function _log_action_on_tracker has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def _log_action_on_tracker(self, tracker, action_name, events, policy,
      Severity: Minor
      Found in rasa/core/processor.py - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status