RasaHQ/rasa_core

View on GitHub
tests/core/test_server.py

Summary

Maintainability
B
5 hrs
Test Coverage

File test_server.py has 303 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# -*- coding: utf-8 -*-
import json
import os
import tempfile
import uuid
Severity: Minor
Found in tests/core/test_server.py - About 3 hrs to fix

    Function test_stack_training has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def test_stack_training(app,
    Severity: Minor
    Found in tests/core/test_server.py - About 35 mins to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          assert set(js["actions"][0].keys()) == {
              "action",
              "predicted",
              "confidence",
              "policy"}
      Severity: Minor
      Found in tests/core/test_server.py and 1 other location - About 40 mins to fix
      tests/core/test_server.py on lines 284..287

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 34.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          assert set(js["actions"][0].keys()) == {"action",
                                                  "predicted",
                                                  "confidence",
                                                  "policy"}
      Severity: Minor
      Found in tests/core/test_server.py and 1 other location - About 40 mins to fix
      tests/core/test_server.py on lines 209..213

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 34.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status