Sign upLogin

ReactiveX/RxJava

View on GitHub
Star
src/main/java/rx/internal/operators/CachedObservable.java

Summary

Maintainability
D
2 days
Test Coverage

Method replay has a Cognitive Complexity of 57 (exceeds 5 allowed). Consider refactoring.
Open

        public void replay() {
            // make sure there is only a single thread emitting
            synchronized (this) {
                if (emitting) {
                    missed = true;
Severity: Minor
Found in src/main/java/rx/internal/operators/CachedObservable.java - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method replay has 99 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        public void replay() {
            // make sure there is only a single thread emitting
            synchronized (this) {
                if (emitting) {
                    missed = true;
Severity: Major
Found in src/main/java/rx/internal/operators/CachedObservable.java - About 3 hrs to fix

    File CachedObservable.java has 296 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
 * Copyright 2014 Netflix, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
    Severity: Minor
    Found in src/main/java/rx/internal/operators/CachedObservable.java - About 3 hrs to fix

      Method request has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

              @Override
        public void request(long n) {
            for (;;) {
                long r = get();
                if (r < 0) {
      Severity: Minor
      Found in src/main/java/rx/internal/operators/CachedObservable.java - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                                          return;
      Severity: Major
      Found in src/main/java/rx/internal/operators/CachedObservable.java - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                                    return;
        Severity: Major
        Found in src/main/java/rx/internal/operators/CachedObservable.java - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                                          return;
          Severity: Major
          Found in src/main/java/rx/internal/operators/CachedObservable.java - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                                            return;
            Severity: Major
            Found in src/main/java/rx/internal/operators/CachedObservable.java - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                                              return;
              Severity: Major
              Found in src/main/java/rx/internal/operators/CachedObservable.java - About 30 mins to fix

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                            synchronized (connection) {
                ReplayProducer<?>[] a = producers;
                int n = a.length;
                ReplayProducer<?>[] b = new ReplayProducer<?>[n + 1];
                System.arraycopy(a, 0, b, 0, n);
                Severity: Major
                Found in src/main/java/rx/internal/operators/CachedObservable.java and 1 other location - About 1 hr to fix
                src/main/java/rx/internal/operators/OperatorMerge.java on lines 286..293

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 76.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                                for (int i = 0; i < n; i++) {
                    if (a[i].equals(p)) {
                        j = i;
                        break;
                    }
                Severity: Minor
                Found in src/main/java/rx/internal/operators/CachedObservable.java and 1 other location - About 35 mins to fix
                src/main/java/rx/internal/operators/OperatorPublish.java on lines 359..364

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 44.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                                    synchronized (this) {
                        if (!missed) {
                            emitting = false;
                            skipFinal = true;
                            return;
                Severity: Minor
                Found in src/main/java/rx/internal/operators/CachedObservable.java and 1 other location - About 30 mins to fix
                src/main/java/rx/internal/operators/OperatorPublish.java on lines 614..627

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 40.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 3 locations. Consider refactoring.
                Open

                                                    if (!NotificationLite.isError(o) && !NotificationLite.isCompleted(o)) {
                                        child.onError(OnErrorThrowable.addValueAsLastCause(err, NotificationLite.getValue(o)));
                                    }
                Severity: Minor
                Found in src/main/java/rx/internal/operators/CachedObservable.java and 2 other locations - About 30 mins to fix
                src/main/java/rx/internal/operators/OperatorReplay.java on lines 909..911
                src/main/java/rx/internal/operators/OperatorReplay.java on lines 1104..1106

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 40.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status