Sign upLogin

ReactiveX/RxJava

View on GitHub
Star
src/main/java/rx/internal/operators/OnSubscribeCombineLatest.java

Summary

Maintainability
D
2 days
Test Coverage

File OnSubscribeCombineLatest.java has 328 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * Copyright 2015 Netflix, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in
 * compliance with the License. You may obtain a copy of the License at
Severity: Minor
Found in src/main/java/rx/internal/operators/OnSubscribeCombineLatest.java - About 3 hrs to fix

    Method drain has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
    Open

            void drain() {
            if (getAndIncrement() != 0) {
                return;
            }
    Severity: Minor
    Found in src/main/java/rx/internal/operators/OnSubscribeCombineLatest.java - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method checkTerminated has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

            boolean checkTerminated(boolean mainDone, boolean queueEmpty, Subscriber<?> childSubscriber, Queue<?> q, boolean delayError) {
            if (cancelled) {
                cancel(q);
                return true;
            }
    Severity: Minor
    Found in src/main/java/rx/internal/operators/OnSubscribeCombineLatest.java - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method drain has 54 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            void drain() {
            if (getAndIncrement() != 0) {
                return;
            }
    Severity: Major
    Found in src/main/java/rx/internal/operators/OnSubscribeCombineLatest.java - About 2 hrs to fix

      Method combine has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

              void combine(Object value, int index) {
            CombinerSubscriber<T, R> combinerSubscriber = subscribers[index];

            int activeCount;
            int completedCount;
      Severity: Minor
      Found in src/main/java/rx/internal/operators/OnSubscribeCombineLatest.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method call has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          @Override
    @SuppressWarnings({ "unchecked", "rawtypes" })
    public void call(Subscriber<? super R> s) {
        Observable<? extends T>[] sources = this.sources;
        int count = 0;
      Severity: Minor
      Found in src/main/java/rx/internal/operators/OnSubscribeCombineLatest.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method combine has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              void combine(Object value, int index) {
            CombinerSubscriber<T, R> combinerSubscriber = subscribers[index];

            int activeCount;
            int completedCount;
      Severity: Minor
      Found in src/main/java/rx/internal/operators/OnSubscribeCombineLatest.java - About 1 hr to fix

        Method checkTerminated has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                boolean checkTerminated(boolean mainDone, boolean queueEmpty, Subscriber<?> childSubscriber, Queue<?> q, boolean delayError) {
            if (cancelled) {
                cancel(q);
                return true;
            }
        Severity: Minor
        Found in src/main/java/rx/internal/operators/OnSubscribeCombineLatest.java - About 1 hr to fix

          Method onError has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

                  void onError(Throwable e) {
            AtomicReference<Throwable> localError = this.error;
            for (;;) {
                Throwable curr = localError.get();
                Throwable next;
          Severity: Minor
          Found in src/main/java/rx/internal/operators/OnSubscribeCombineLatest.java - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method call has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              @Override
    @SuppressWarnings({ "unchecked", "rawtypes" })
    public void call(Subscriber<? super R> s) {
        Observable<? extends T>[] sources = this.sources;
        int count = 0;
          Severity: Minor
          Found in src/main/java/rx/internal/operators/OnSubscribeCombineLatest.java - About 1 hr to fix

            Method checkTerminated has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    boolean checkTerminated(boolean mainDone, boolean queueEmpty, Subscriber<?> childSubscriber, Queue<?> q, boolean delayError) {
            Severity: Minor
            Found in src/main/java/rx/internal/operators/OnSubscribeCombineLatest.java - About 35 mins to fix

              Avoid too many return statements within this method.
              Open

                                      return;
              Severity: Major
              Found in src/main/java/rx/internal/operators/OnSubscribeCombineLatest.java - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                            return false;
                Severity: Major
                Found in src/main/java/rx/internal/operators/OnSubscribeCombineLatest.java - About 30 mins to fix

                  Similar blocks of code found in 13 locations. Consider refactoring.
                  Open

                      public OnSubscribeCombineLatest(Observable<? extends T>[] sources,
            Iterable<? extends Observable<? extends T>> sourcesIterable,
            FuncN<? extends R> combiner, int bufferSize,
            boolean delayError) {
        this.sources = sources;
                  Severity: Major
                  Found in src/main/java/rx/internal/operators/OnSubscribeCombineLatest.java and 12 other locations - About 50 mins to fix
                  src/main/java/rx/internal/operators/CompletableOnSubscribeTimeout.java on lines 36..43
                  src/main/java/rx/internal/operators/OnSubscribeGroupJoin.java on lines 47..58
                  src/main/java/rx/internal/operators/OnSubscribeJoin.java on lines 44..55
                  src/main/java/rx/internal/operators/OnSubscribeRedo.java on lines 177..184
                  src/main/java/rx/internal/operators/OnSubscribeTimeoutTimedWithFallback.java on lines 48..56
                  src/main/java/rx/internal/operators/OperatorBufferWithTime.java on lines 62..68
                  src/main/java/rx/internal/operators/OperatorGroupBy.java on lines 69..75
                  src/main/java/rx/internal/operators/OperatorGroupByEvicting.java on lines 63..69
                  src/main/java/rx/internal/operators/OperatorRetryWithPredicate.java on lines 54..64
                  src/main/java/rx/internal/operators/OperatorWindowWithTime.java on lines 53..59
                  src/main/java/rx/internal/operators/SingleTimeout.java on lines 38..45
                  src/main/java/rx/internal/util/InternalObservableUtils.java on lines 343..350

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 60.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                                      if (count == sources.length) {
                        Observable<? extends T>[] b = new Observable[count + (count >> 2)];
                        System.arraycopy(sources, 0, b, 0, count);
                        sources = b;
                    }
                  Severity: Minor
                  Found in src/main/java/rx/internal/operators/OnSubscribeCombineLatest.java and 1 other location - About 50 mins to fix
                  src/main/java/rx/Single.java on lines 2586..2590

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 58.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status