Sign upLogin

ReactiveX/RxJava

View on GitHub
Star
src/main/java/rx/internal/operators/OnSubscribeGroupJoin.java

Summary

Maintainability
B
5 hrs
Test Coverage

File OnSubscribeGroupJoin.java has 283 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * Copyright 2014 Netflix, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
Severity: Minor
Found in src/main/java/rx/internal/operators/OnSubscribeGroupJoin.java - About 2 hrs to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                @Override
            public void onCompleted() {
                List<Observer<T2>> list = null;
                synchronized (ResultManager.this) {
                    leftDone = true;
    Severity: Minor
    Found in src/main/java/rx/internal/operators/OnSubscribeGroupJoin.java and 1 other location - About 55 mins to fix
    src/main/java/rx/internal/operators/OnSubscribeGroupJoin.java on lines 249..261

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                @Override
            public void onCompleted() {
                List<Observer<T2>> list = null;
                synchronized (ResultManager.this) {
                    rightDone = true;
    Severity: Minor
    Found in src/main/java/rx/internal/operators/OnSubscribeGroupJoin.java and 1 other location - About 55 mins to fix
    src/main/java/rx/internal/operators/OnSubscribeGroupJoin.java on lines 199..211

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 13 locations. Consider refactoring.
    Open

        public OnSubscribeGroupJoin(
            Observable<T1> left,
            Observable<T2> right,
            Func1<? super T1, ? extends Observable<D1>> leftDuration,
            Func1<? super T2, ? extends Observable<D2>> rightDuration,
    Severity: Major
    Found in src/main/java/rx/internal/operators/OnSubscribeGroupJoin.java and 12 other locations - About 50 mins to fix
    src/main/java/rx/internal/operators/CompletableOnSubscribeTimeout.java on lines 36..43
    src/main/java/rx/internal/operators/OnSubscribeCombineLatest.java on lines 40..49
    src/main/java/rx/internal/operators/OnSubscribeJoin.java on lines 44..55
    src/main/java/rx/internal/operators/OnSubscribeRedo.java on lines 177..184
    src/main/java/rx/internal/operators/OnSubscribeTimeoutTimedWithFallback.java on lines 48..56
    src/main/java/rx/internal/operators/OperatorBufferWithTime.java on lines 62..68
    src/main/java/rx/internal/operators/OperatorGroupBy.java on lines 69..75
    src/main/java/rx/internal/operators/OperatorGroupByEvicting.java on lines 63..69
    src/main/java/rx/internal/operators/OperatorRetryWithPredicate.java on lines 54..64
    src/main/java/rx/internal/operators/OperatorWindowWithTime.java on lines 53..59
    src/main/java/rx/internal/operators/SingleTimeout.java on lines 38..45
    src/main/java/rx/internal/util/InternalObservableUtils.java on lines 343..350

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status