Sign upLogin

ReactiveX/RxJava

View on GitHub
Star
src/main/java/rx/internal/operators/OnSubscribeRedo.java

Summary

Maintainability
D
2 days
Test Coverage

Method call has 134 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @Override
    public void call(final Subscriber<? super T> child) {

        // when true is a marker to say we are ready to resubscribe to source
        final AtomicBoolean resumeBoundary = new AtomicBoolean(true);
Severity: Major
Found in src/main/java/rx/internal/operators/OnSubscribeRedo.java - About 5 hrs to fix

    Method call has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
    Open

        @Override
    public void call(final Subscriber<? super T> child) {

        // when true is a marker to say we are ready to resubscribe to source
        final AtomicBoolean resumeBoundary = new AtomicBoolean(true);
    Severity: Minor
    Found in src/main/java/rx/internal/operators/OnSubscribeRedo.java - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    OnSubscribeRedo has 31 methods (exceeds 20 allowed). Consider refactoring.
    Open

    public final class OnSubscribeRedo<T> implements OnSubscribe<T> {
    final Observable<T> source;
    private final Func1<? super Observable<? extends Notification<?>>, ? extends Observable<?>> controlHandlerFunction;
    final boolean stopOnComplete;
    final boolean stopOnError;
    Severity: Minor
    Found in src/main/java/rx/internal/operators/OnSubscribeRedo.java - About 3 hrs to fix

      File OnSubscribeRedo.java has 264 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /**
 * Copyright 2014 Netflix, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
      Severity: Minor
      Found in src/main/java/rx/internal/operators/OnSubscribeRedo.java - About 2 hrs to fix

        Method call has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

                    @Override
            public void call() {
                if (child.isUnsubscribed()) {
                    return;
                }
        Severity: Minor
        Found in src/main/java/rx/internal/operators/OnSubscribeRedo.java - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 13 locations. Consider refactoring.
        Open

            private OnSubscribeRedo(Observable<T> source, Func1<? super Observable<? extends Notification<?>>, ? extends Observable<?>> f, boolean stopOnComplete, boolean stopOnError,
            Scheduler scheduler) {
        this.source = source;
        this.controlHandlerFunction = f;
        this.stopOnComplete = stopOnComplete;
        Severity: Major
        Found in src/main/java/rx/internal/operators/OnSubscribeRedo.java and 12 other locations - About 50 mins to fix
        src/main/java/rx/internal/operators/CompletableOnSubscribeTimeout.java on lines 36..43
        src/main/java/rx/internal/operators/OnSubscribeCombineLatest.java on lines 40..49
        src/main/java/rx/internal/operators/OnSubscribeGroupJoin.java on lines 47..58
        src/main/java/rx/internal/operators/OnSubscribeJoin.java on lines 44..55
        src/main/java/rx/internal/operators/OnSubscribeTimeoutTimedWithFallback.java on lines 48..56
        src/main/java/rx/internal/operators/OperatorBufferWithTime.java on lines 62..68
        src/main/java/rx/internal/operators/OperatorGroupBy.java on lines 69..75
        src/main/java/rx/internal/operators/OperatorGroupByEvicting.java on lines 63..69
        src/main/java/rx/internal/operators/OperatorRetryWithPredicate.java on lines 54..64
        src/main/java/rx/internal/operators/OperatorWindowWithTime.java on lines 53..59
        src/main/java/rx/internal/operators/SingleTimeout.java on lines 38..45
        src/main/java/rx/internal/util/InternalObservableUtils.java on lines 343..350

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 60.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status