Sign upLogin

ReactiveX/RxJava

View on GitHub
Star
src/main/java/rx/internal/operators/OperatorBufferWithTime.java

Summary

Maintainability
B
5 hrs
Test Coverage

Method onNext has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

        @Override
        public void onNext(T t) {
            List<List<T>> sizeReached = null;
            synchronized (this) {
                if (done) {
Severity: Minor
Found in src/main/java/rx/internal/operators/OperatorBufferWithTime.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method emitChunk has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

        void emitChunk(List<T> chunkToEmit) {
            boolean emit = false;
            synchronized (this) {
                if (done) {
                    return;
Severity: Minor
Found in src/main/java/rx/internal/operators/OperatorBufferWithTime.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        @Override
        public void onCompleted() {
            try {
                List<List<T>> sizeReached;
                synchronized (this) {
Severity: Major
Found in src/main/java/rx/internal/operators/OperatorBufferWithTime.java and 1 other location - About 1 hr to fix
src/main/java/rx/internal/operators/OperatorBufferWithStartEndObservable.java on lines 133..154

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 95.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

    public OperatorBufferWithTime(long timespan, long timeshift, TimeUnit unit, int count, Scheduler scheduler) {
        this.timespan = timespan;
        this.timeshift = timeshift;
        this.unit = unit;
        this.count = count;
Severity: Major
Found in src/main/java/rx/internal/operators/OperatorBufferWithTime.java and 12 other locations - About 50 mins to fix
src/main/java/rx/internal/operators/CompletableOnSubscribeTimeout.java on lines 36..43
src/main/java/rx/internal/operators/OnSubscribeCombineLatest.java on lines 40..49
src/main/java/rx/internal/operators/OnSubscribeGroupJoin.java on lines 47..58
src/main/java/rx/internal/operators/OnSubscribeJoin.java on lines 44..55
src/main/java/rx/internal/operators/OnSubscribeRedo.java on lines 177..184
src/main/java/rx/internal/operators/OnSubscribeTimeoutTimedWithFallback.java on lines 48..56
src/main/java/rx/internal/operators/OperatorGroupBy.java on lines 69..75
src/main/java/rx/internal/operators/OperatorGroupByEvicting.java on lines 63..69
src/main/java/rx/internal/operators/OperatorRetryWithPredicate.java on lines 54..64
src/main/java/rx/internal/operators/OperatorWindowWithTime.java on lines 53..59
src/main/java/rx/internal/operators/SingleTimeout.java on lines 38..45
src/main/java/rx/internal/util/InternalObservableUtils.java on lines 343..350

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        @Override
        public void onError(Throwable e) {
            synchronized (this) {
                if (done) {
                    return;
Severity: Minor
Found in src/main/java/rx/internal/operators/OperatorBufferWithTime.java and 1 other location - About 35 mins to fix
src/main/java/rx/internal/operators/OperatorBufferWithSingleObservable.java on lines 133..144

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        @Override
        public void onError(Throwable e) {
            synchronized (this) {
                if (done) {
                    return;
Severity: Minor
Found in src/main/java/rx/internal/operators/OperatorBufferWithTime.java and 1 other location - About 35 mins to fix
src/main/java/rx/internal/operators/OperatorBufferWithStartEndObservable.java on lines 120..131

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status