Sign upLogin

ReactiveX/RxJava

View on GitHub
Star
src/main/java/rx/internal/operators/OperatorGroupBy.java

Summary

Maintainability
F
4 days
Test Coverage

File OperatorGroupBy.java has 476 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * Copyright 2014 Netflix, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
Severity: Minor
Found in src/main/java/rx/internal/operators/OperatorGroupBy.java - About 7 hrs to fix

    Method drain has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
    Open

            void drain() {
            if (getAndIncrement() != 0) {
                return;
            }
            int missed = 1;
    Severity: Minor
    Found in src/main/java/rx/internal/operators/OperatorGroupBy.java - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method drain has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

            void drain() {
            if (wip.getAndIncrement() != 0) {
                return;
            }
    Severity: Minor
    Found in src/main/java/rx/internal/operators/OperatorGroupBy.java - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method onNext has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

            @Override
        public void onNext(T t) {
            if (done) {
                return;
            }
    Severity: Minor
    Found in src/main/java/rx/internal/operators/OperatorGroupBy.java - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method checkTerminated has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

            boolean checkTerminated(boolean d, boolean empty, Subscriber<? super T> a, boolean delayError) {
            if (cancelled.get()) {
                queue.clear();
                parent.cancel(key);
                return true;
    Severity: Minor
    Found in src/main/java/rx/internal/operators/OperatorGroupBy.java - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method onNext has 51 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            @Override
        public void onNext(T t) {
            if (done) {
                return;
            }
    Severity: Major
    Found in src/main/java/rx/internal/operators/OperatorGroupBy.java - About 2 hrs to fix

      Method drain has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              void drain() {
            if (getAndIncrement() != 0) {
                return;
            }
            int missed = 1;
      Severity: Minor
      Found in src/main/java/rx/internal/operators/OperatorGroupBy.java - About 1 hr to fix

        Method drain has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                void drain() {
            if (wip.getAndIncrement() != 0) {
                return;
            }
        Severity: Minor
        Found in src/main/java/rx/internal/operators/OperatorGroupBy.java - About 1 hr to fix

          Method checkTerminated has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  boolean checkTerminated(boolean d, boolean empty, Subscriber<? super T> a, boolean delayError) {
            if (cancelled.get()) {
                queue.clear();
                parent.cancel(key);
                return true;
          Severity: Minor
          Found in src/main/java/rx/internal/operators/OperatorGroupBy.java - About 1 hr to fix

            Avoid too many return statements within this method.
            Open

                        return false;
            Severity: Major
            Found in src/main/java/rx/internal/operators/OperatorGroupBy.java - About 30 mins to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                      boolean checkTerminated(boolean d, boolean empty, Subscriber<? super T> a, boolean delayError) {
            if (cancelled.get()) {
                queue.clear();
                parent.cancel(key);
                return true;
              Severity: Major
              Found in src/main/java/rx/internal/operators/OperatorGroupBy.java and 1 other location - About 2 hrs to fix
              src/main/java/rx/internal/operators/OperatorGroupByEvicting.java on lines 570..603

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 147.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                      public State(int bufferSize, GroupBySubscriber<?, K, T> parent, K key, boolean delayError) { // NOPMD
            this.queue = new ConcurrentLinkedQueue<Object>();
            this.parent = parent;
            this.key = key;
            this.delayError = delayError;
              Severity: Major
              Found in src/main/java/rx/internal/operators/OperatorGroupBy.java and 1 other location - About 1 hr to fix
              src/main/java/rx/internal/operators/OperatorGroupByEvicting.java on lines 445..454

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 89.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                              while (e != r) {
                    boolean d = done;

                    GroupedObservable<K, V> t = q.poll();
              Severity: Major
              Found in src/main/java/rx/internal/operators/OperatorGroupBy.java and 1 other location - About 1 hr to fix
              src/main/java/rx/internal/operators/OperatorWindowWithSize.java on lines 419..435

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 78.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                      boolean checkTerminated(boolean d, boolean empty,
                Subscriber<? super GroupedObservable<K, V>> a, Queue<?> q) {
            if (d) {
                Throwable err = error;
                if (err != null) {
              Severity: Minor
              Found in src/main/java/rx/internal/operators/OperatorGroupBy.java and 1 other location - About 55 mins to fix
              src/main/java/rx/internal/operators/OperatorGroupByEvicting.java on lines 366..380

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 65.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 13 locations. Consider refactoring.
              Open

                  public OperatorGroupBy(Func1<? super T, ? extends K> keySelector, Func1<? super T, ? extends V> valueSelector, int bufferSize, boolean delayError, Func1<Action1<K>, Map<K, Object>> mapFactory) {
        this.keySelector = keySelector;
        this.valueSelector = valueSelector;
        this.bufferSize = bufferSize;
        this.delayError = delayError;
              Severity: Major
              Found in src/main/java/rx/internal/operators/OperatorGroupBy.java and 12 other locations - About 50 mins to fix
              src/main/java/rx/internal/operators/CompletableOnSubscribeTimeout.java on lines 36..43
              src/main/java/rx/internal/operators/OnSubscribeCombineLatest.java on lines 40..49
              src/main/java/rx/internal/operators/OnSubscribeGroupJoin.java on lines 47..58
              src/main/java/rx/internal/operators/OnSubscribeJoin.java on lines 44..55
              src/main/java/rx/internal/operators/OnSubscribeRedo.java on lines 177..184
              src/main/java/rx/internal/operators/OnSubscribeTimeoutTimedWithFallback.java on lines 48..56
              src/main/java/rx/internal/operators/OperatorBufferWithTime.java on lines 62..68
              src/main/java/rx/internal/operators/OperatorGroupByEvicting.java on lines 63..69
              src/main/java/rx/internal/operators/OperatorRetryWithPredicate.java on lines 54..64
              src/main/java/rx/internal/operators/OperatorWindowWithTime.java on lines 53..59
              src/main/java/rx/internal/operators/SingleTimeout.java on lines 38..45
              src/main/java/rx/internal/util/InternalObservableUtils.java on lines 343..350

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 60.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                      @Override
        public void call(Subscriber<? super T> s) {
            if (once.compareAndSet(false, true)) {
                s.add(this);
                s.setProducer(this);
              Severity: Minor
              Found in src/main/java/rx/internal/operators/OperatorGroupBy.java and 1 other location - About 45 mins to fix
              src/main/java/rx/internal/operators/OperatorGroupByEvicting.java on lines 481..491

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 56.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                      @Override
        public void request(long n) {
            if (n < 0) {
                throw new IllegalArgumentException("n >= required but it was " + n);
            }
              Severity: Minor
              Found in src/main/java/rx/internal/operators/OperatorGroupBy.java and 1 other location - About 40 mins to fix
              src/main/java/rx/internal/operators/OperatorGroupByEvicting.java on lines 456..465

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 48.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                      public void onNext(T t) {
            if (t == null) {
                error = new NullPointerException();
                done = true;
            } else {
              Severity: Minor
              Found in src/main/java/rx/internal/operators/OperatorGroupBy.java and 1 other location - About 40 mins to fix
              src/main/java/rx/internal/operators/OperatorGroupByEvicting.java on lines 493..501

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 48.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                      @Override
        public void onError(Throwable t) {
            if (done) {
                RxJavaHooks.onError(t);
                return;
              Severity: Minor
              Found in src/main/java/rx/internal/operators/OperatorGroupBy.java and 1 other location - About 35 mins to fix
              src/main/java/rx/internal/operators/OperatorGroupByEvicting.java on lines 237..247

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status