Sign upLogin

ReactiveX/RxJava

View on GitHub
Star
src/main/java/rx/internal/operators/OperatorGroupByEvicting.java

Summary

Maintainability
F
4 days
Test Coverage

File OperatorGroupByEvicting.java has 470 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * Copyright 2018 Netflix, Inc.
 * 
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
Severity: Minor
Found in src/main/java/rx/internal/operators/OperatorGroupByEvicting.java - About 7 hrs to fix

    Method drain has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
    Open

            void drain() {
            if (getAndIncrement() != 0) {
                return;
            }
            int missed = 1;
    Severity: Minor
    Found in src/main/java/rx/internal/operators/OperatorGroupByEvicting.java - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method drain has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

            void drain() {
            if (wip.getAndIncrement() != 0) {
                return;
            }
    Severity: Minor
    Found in src/main/java/rx/internal/operators/OperatorGroupByEvicting.java - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method checkTerminated has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

            boolean checkTerminated(boolean d, boolean empty, Subscriber<? super T> a, boolean delayError) {
            if (cancelled.get()) {
                queue.clear();
                parent.cancel(key);
                return true;
    Severity: Minor
    Found in src/main/java/rx/internal/operators/OperatorGroupByEvicting.java - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method onNext has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            @Override
        public void onNext(T t) {
            if (done) {
                return;
            }
    Severity: Minor
    Found in src/main/java/rx/internal/operators/OperatorGroupByEvicting.java - About 1 hr to fix

      Method drain has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              void drain() {
            if (getAndIncrement() != 0) {
                return;
            }
            int missed = 1;
      Severity: Minor
      Found in src/main/java/rx/internal/operators/OperatorGroupByEvicting.java - About 1 hr to fix

        Method onNext has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

                @Override
        public void onNext(T t) {
            if (done) {
                return;
            }
        Severity: Minor
        Found in src/main/java/rx/internal/operators/OperatorGroupByEvicting.java - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method drain has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                void drain() {
            if (wip.getAndIncrement() != 0) {
                return;
            }
        Severity: Minor
        Found in src/main/java/rx/internal/operators/OperatorGroupByEvicting.java - About 1 hr to fix

          Method checkTerminated has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  boolean checkTerminated(boolean d, boolean empty, Subscriber<? super T> a, boolean delayError) {
            if (cancelled.get()) {
                queue.clear();
                parent.cancel(key);
                return true;
          Severity: Minor
          Found in src/main/java/rx/internal/operators/OperatorGroupByEvicting.java - About 1 hr to fix

            Method call has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                @SuppressWarnings("unchecked")
    @Override
    public Subscriber<? super T> call(Subscriber<? super GroupedObservable<K, V>> child) {
        Map<K, GroupedUnicast<K, V>> groups;
        Queue<GroupedUnicast<K, V>> evictedGroups;
            Severity: Minor
            Found in src/main/java/rx/internal/operators/OperatorGroupByEvicting.java - About 1 hr to fix

              Avoid too many return statements within this method.
              Open

                          return false;
              Severity: Major
              Found in src/main/java/rx/internal/operators/OperatorGroupByEvicting.java - About 30 mins to fix

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        boolean checkTerminated(boolean d, boolean empty, Subscriber<? super T> a, boolean delayError) {
            if (cancelled.get()) {
                queue.clear();
                parent.cancel(key);
                return true;
                Severity: Major
                Found in src/main/java/rx/internal/operators/OperatorGroupByEvicting.java and 1 other location - About 2 hrs to fix
                src/main/java/rx/internal/operators/OperatorGroupBy.java on lines 583..616

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 147.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        public State(int bufferSize, GroupBySubscriber<?, K, T> parent, K key, boolean delayError) {
            this.queue = new ConcurrentLinkedQueue<Object>();
            this.parent = parent;
            this.key = key;
            this.delayError = delayError;
                Severity: Major
                Found in src/main/java/rx/internal/operators/OperatorGroupByEvicting.java and 1 other location - About 1 hr to fix
                src/main/java/rx/internal/operators/OperatorGroupBy.java on lines 460..469

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 89.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        boolean checkTerminated(boolean d, boolean empty, 
                Subscriber<? super GroupedObservable<K, V>> a, Queue<?> q) {
            if (d) {
                Throwable err = error;
                if (err != null) {
                Severity: Minor
                Found in src/main/java/rx/internal/operators/OperatorGroupByEvicting.java and 1 other location - About 55 mins to fix
                src/main/java/rx/internal/operators/OperatorGroupBy.java on lines 395..409

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 65.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 13 locations. Consider refactoring.
                Open

                    public OperatorGroupByEvicting(Func1<? super T, ? extends K> keySelector, Func1<? super T, ? extends V> valueSelector, int bufferSize, boolean delayError, Func1<Action1<Object>, Map<K, Object>> mapFactory) {
        this.keySelector = keySelector;
        this.valueSelector = valueSelector;
        this.bufferSize = bufferSize;
        this.delayError = delayError;
                Severity: Major
                Found in src/main/java/rx/internal/operators/OperatorGroupByEvicting.java and 12 other locations - About 50 mins to fix
                src/main/java/rx/internal/operators/CompletableOnSubscribeTimeout.java on lines 36..43
                src/main/java/rx/internal/operators/OnSubscribeCombineLatest.java on lines 40..49
                src/main/java/rx/internal/operators/OnSubscribeGroupJoin.java on lines 47..58
                src/main/java/rx/internal/operators/OnSubscribeJoin.java on lines 44..55
                src/main/java/rx/internal/operators/OnSubscribeRedo.java on lines 177..184
                src/main/java/rx/internal/operators/OnSubscribeTimeoutTimedWithFallback.java on lines 48..56
                src/main/java/rx/internal/operators/OperatorBufferWithTime.java on lines 62..68
                src/main/java/rx/internal/operators/OperatorGroupBy.java on lines 69..75
                src/main/java/rx/internal/operators/OperatorRetryWithPredicate.java on lines 54..64
                src/main/java/rx/internal/operators/OperatorWindowWithTime.java on lines 53..59
                src/main/java/rx/internal/operators/SingleTimeout.java on lines 38..45
                src/main/java/rx/internal/util/InternalObservableUtils.java on lines 343..350

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 60.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        @Override
        public void call(Subscriber<? super T> s) {
            if (once.compareAndSet(false, true)) {
                s.add(this);
                s.setProducer(this);
                Severity: Minor
                Found in src/main/java/rx/internal/operators/OperatorGroupByEvicting.java and 1 other location - About 45 mins to fix
                src/main/java/rx/internal/operators/OperatorGroupBy.java on lines 496..506

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 56.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        @Override
        public void request(long n) {
            if (n < 0) {
                throw new IllegalArgumentException("n >= required but it was " + n);
            }
                Severity: Minor
                Found in src/main/java/rx/internal/operators/OperatorGroupByEvicting.java and 1 other location - About 40 mins to fix
                src/main/java/rx/internal/operators/OperatorGroupBy.java on lines 471..480

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 48.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        public void onNext(T t) {
            if (t == null) {
                error = new NullPointerException();
                done = true;
            } else {
                Severity: Minor
                Found in src/main/java/rx/internal/operators/OperatorGroupByEvicting.java and 1 other location - About 40 mins to fix
                src/main/java/rx/internal/operators/OperatorGroupBy.java on lines 508..516

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 48.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        @Override
        public void onError(Throwable t) {
            if (done) {
                RxJavaHooks.onError(t);
                return;
                Severity: Minor
                Found in src/main/java/rx/internal/operators/OperatorGroupByEvicting.java and 1 other location - About 35 mins to fix
                src/main/java/rx/internal/operators/OperatorGroupBy.java on lines 263..273

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 46.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status