Sign upLogin

ReactiveX/RxJava

View on GitHub
Star
src/main/java/rx/internal/operators/OperatorZip.java

Summary

Maintainability
C
1 day
Test Coverage

Method tick has a Cognitive Complexity of 55 (exceeds 5 allowed). Consider refactoring.
Open

        @SuppressWarnings("unchecked")
        void tick() {
            final Object[] subscribers = this.subscribers;
            if (subscribers == null) {
                // nothing yet to do (initial request from Producer)
Severity: Minor
Found in src/main/java/rx/internal/operators/OperatorZip.java - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method tick has 57 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        @SuppressWarnings("unchecked")
        void tick() {
            final Object[] subscribers = this.subscribers;
            if (subscribers == null) {
                // nothing yet to do (initial request from Producer)
Severity: Major
Found in src/main/java/rx/internal/operators/OperatorZip.java - About 2 hrs to fix

    Avoid deeply nested control flow statements.
    Open

                                    if (buffer.isCompleted(buffer.peek())) {
                                    // it is an onComplete so shut down
                                    child.onCompleted();
                                    // we need to unsubscribe from all children since children are independently subscribed
                                    childSubscription.unsubscribe();
    Severity: Major
    Found in src/main/java/rx/internal/operators/OperatorZip.java - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                                      for (Object obj : subscribers) {
                                    ((InnerSubscriber) obj).requestMore(emitted);
                                }
      Severity: Major
      Found in src/main/java/rx/internal/operators/OperatorZip.java - About 45 mins to fix

        There are no issues that match your filters.

        Category
        Status