Sign upLogin

ReactiveX/RxJava

View on GitHub
Star
src/main/java/rx/internal/util/unsafe/SpmcArrayQueue.java

Summary

Maintainability
C
7 hrs
Test Coverage

Method offer has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    public boolean offer(final E e) {
        if (null == e) {
            throw new NullPointerException("Null is not a valid element");
        }
Severity: Minor
Found in src/main/java/rx/internal/util/unsafe/SpmcArrayQueue.java - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method peek has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    public E peek() {
        long currentConsumerIndex;
        final long currProducerIndexCache = lvProducerIndexCache();
        E e;
Severity: Minor
Found in src/main/java/rx/internal/util/unsafe/SpmcArrayQueue.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method poll has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    public E poll() {
        long currentConsumerIndex;
        final long currProducerIndexCache = lvProducerIndexCache();
        do {
Severity: Minor
Found in src/main/java/rx/internal/util/unsafe/SpmcArrayQueue.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 7 locations. Consider refactoring.
Open

    @Override
    public int size() {
        /*
         * It is possible for a thread to be interrupted or reschedule between the read of the producer and consumer
         * indices, therefore protection is required to ensure size is within valid range. In the event of concurrent
Severity: Major
Found in src/main/java/rx/internal/util/unsafe/SpmcArrayQueue.java and 6 other locations - About 55 mins to fix
src/main/java/rx/internal/util/atomic/SpscAtomicArrayQueue.java on lines 92..108
src/main/java/rx/internal/util/atomic/SpscLinkedArrayQueue.java on lines 191..208
src/main/java/rx/internal/util/atomic/SpscUnboundedAtomicArrayQueue.java on lines 191..208
src/main/java/rx/internal/util/unsafe/MpmcArrayQueue.java on lines 216..233
src/main/java/rx/internal/util/unsafe/SpscArrayQueue.java on lines 153..169
src/main/java/rx/internal/util/unsafe/SpscUnboundedArrayQueue.java on lines 235..252

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

@SuppressAnimalSniffer
abstract class SpmcArrayQueueConsumerField<E> extends SpmcArrayQueueL2Pad<E> {
    protected final static long C_INDEX_OFFSET = UnsafeAccess.addressOf(SpmcArrayQueueConsumerField.class, "consumerIndex");
    private volatile long consumerIndex;
Severity: Major
Found in src/main/java/rx/internal/util/unsafe/SpmcArrayQueue.java and 2 other locations - About 50 mins to fix
src/main/java/rx/internal/util/unsafe/MpmcArrayQueue.java on lines 32..48
src/main/java/rx/internal/util/unsafe/MpmcArrayQueue.java on lines 59..75

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 58.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        do {
            currentConsumerIndex = lvConsumerIndex();
            if (currentConsumerIndex >= currProducerIndexCache) {
                long currProducerIndex = lvProducerIndex();
                if (currentConsumerIndex >= currProducerIndex) {
Severity: Minor
Found in src/main/java/rx/internal/util/unsafe/SpmcArrayQueue.java and 1 other location - About 40 mins to fix
src/main/java/rx/internal/util/unsafe/SpmcArrayQueue.java on lines 179..189

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        do {
            currentConsumerIndex = lvConsumerIndex();
            if (currentConsumerIndex >= currProducerIndexCache) {
                long currProducerIndex = lvProducerIndex();
                if (currentConsumerIndex >= currProducerIndex) {
Severity: Minor
Found in src/main/java/rx/internal/util/unsafe/SpmcArrayQueue.java and 1 other location - About 40 mins to fix
src/main/java/rx/internal/util/unsafe/SpmcArrayQueue.java on lines 152..162

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

abstract class SpmcArrayQueueL2Pad<E> extends SpmcArrayQueueProducerField<E> {
    long p20, p21, p22, p23, p24, p25, p26;
    long p30, p31, p32, p33, p34, p35, p36, p37;

    public SpmcArrayQueueL2Pad(int capacity) {
Severity: Major
Found in src/main/java/rx/internal/util/unsafe/SpmcArrayQueue.java and 8 other locations - About 35 mins to fix
src/main/java/rx/internal/util/unsafe/MpmcArrayQueue.java on lines 23..30
src/main/java/rx/internal/util/unsafe/MpmcArrayQueue.java on lines 50..57
src/main/java/rx/internal/util/unsafe/SpmcArrayQueue.java on lines 23..30
src/main/java/rx/internal/util/unsafe/SpmcArrayQueue.java on lines 77..84
src/main/java/rx/internal/util/unsafe/SpmcArrayQueue.java on lines 105..112
src/main/java/rx/internal/util/unsafe/SpscArrayQueue.java on lines 31..38
src/main/java/rx/internal/util/unsafe/SpscArrayQueue.java on lines 51..58
src/main/java/rx/internal/util/unsafe/SpscArrayQueue.java on lines 69..76

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

abstract class SpmcArrayQueueMidPad<E> extends SpmcArrayQueueConsumerField<E> {
    long p20, p21, p22, p23, p24, p25, p26;
    long p30, p31, p32, p33, p34, p35, p36, p37;

    public SpmcArrayQueueMidPad(int capacity) {
Severity: Major
Found in src/main/java/rx/internal/util/unsafe/SpmcArrayQueue.java and 8 other locations - About 35 mins to fix
src/main/java/rx/internal/util/unsafe/MpmcArrayQueue.java on lines 23..30
src/main/java/rx/internal/util/unsafe/MpmcArrayQueue.java on lines 50..57
src/main/java/rx/internal/util/unsafe/SpmcArrayQueue.java on lines 23..30
src/main/java/rx/internal/util/unsafe/SpmcArrayQueue.java on lines 50..57
src/main/java/rx/internal/util/unsafe/SpmcArrayQueue.java on lines 105..112
src/main/java/rx/internal/util/unsafe/SpscArrayQueue.java on lines 31..38
src/main/java/rx/internal/util/unsafe/SpscArrayQueue.java on lines 51..58
src/main/java/rx/internal/util/unsafe/SpscArrayQueue.java on lines 69..76

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

abstract class SpmcArrayQueueL1Pad<E> extends ConcurrentCircularArrayQueue<E> {
    long p10, p11, p12, p13, p14, p15, p16;
    long p30, p31, p32, p33, p34, p35, p36, p37;

    public SpmcArrayQueueL1Pad(int capacity) {
Severity: Major
Found in src/main/java/rx/internal/util/unsafe/SpmcArrayQueue.java and 8 other locations - About 35 mins to fix
src/main/java/rx/internal/util/unsafe/MpmcArrayQueue.java on lines 23..30
src/main/java/rx/internal/util/unsafe/MpmcArrayQueue.java on lines 50..57
src/main/java/rx/internal/util/unsafe/SpmcArrayQueue.java on lines 50..57
src/main/java/rx/internal/util/unsafe/SpmcArrayQueue.java on lines 77..84
src/main/java/rx/internal/util/unsafe/SpmcArrayQueue.java on lines 105..112
src/main/java/rx/internal/util/unsafe/SpscArrayQueue.java on lines 31..38
src/main/java/rx/internal/util/unsafe/SpscArrayQueue.java on lines 51..58
src/main/java/rx/internal/util/unsafe/SpscArrayQueue.java on lines 69..76

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

abstract class SpmcArrayQueueL3Pad<E> extends SpmcArrayQueueProducerIndexCacheField<E> {
    long p40, p41, p42, p43, p44, p45, p46;
    long p30, p31, p32, p33, p34, p35, p36, p37;

    public SpmcArrayQueueL3Pad(int capacity) {
Severity: Major
Found in src/main/java/rx/internal/util/unsafe/SpmcArrayQueue.java and 8 other locations - About 35 mins to fix
src/main/java/rx/internal/util/unsafe/MpmcArrayQueue.java on lines 23..30
src/main/java/rx/internal/util/unsafe/MpmcArrayQueue.java on lines 50..57
src/main/java/rx/internal/util/unsafe/SpmcArrayQueue.java on lines 23..30
src/main/java/rx/internal/util/unsafe/SpmcArrayQueue.java on lines 50..57
src/main/java/rx/internal/util/unsafe/SpmcArrayQueue.java on lines 77..84
src/main/java/rx/internal/util/unsafe/SpscArrayQueue.java on lines 31..38
src/main/java/rx/internal/util/unsafe/SpscArrayQueue.java on lines 51..58
src/main/java/rx/internal/util/unsafe/SpscArrayQueue.java on lines 69..76

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status