Sign upLogin

ReactiveX/RxJava

View on GitHub
Star
src/perf/java/rx/subscriptions/CompositeSubscriptionConcurrentPerf.java

Summary

Maintainability
C
1 day
Test Coverage

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    @Group("g1")
    @GroupThreads(1)
    @Benchmark
    public void addRemoveT2() {
        CompositeSubscription csub = this.csub;
Severity: Major
Found in src/perf/java/rx/subscriptions/CompositeSubscriptionConcurrentPerf.java and 2 other locations - About 1 hr to fix
src/perf/java/rx/subscriptions/CompositeSubscriptionConcurrentPerf.java on lines 72..87
src/perf/java/rx/subscriptions/CompositeSubscriptionConcurrentPerf.java on lines 152..167

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 119.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    @Group("g3")
    @GroupThreads(1)
    @Benchmark
    public void addClearT2() {
        CompositeSubscription csub = this.csub;
Severity: Major
Found in src/perf/java/rx/subscriptions/CompositeSubscriptionConcurrentPerf.java and 2 other locations - About 1 hr to fix
src/perf/java/rx/subscriptions/CompositeSubscriptionConcurrentPerf.java on lines 72..87
src/perf/java/rx/subscriptions/CompositeSubscriptionConcurrentPerf.java on lines 88..103

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 119.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    @Group("g1")
    @GroupThreads(1)
    @Benchmark
    public void addRemoveT1() {
        CompositeSubscription csub = this.csub;
Severity: Major
Found in src/perf/java/rx/subscriptions/CompositeSubscriptionConcurrentPerf.java and 2 other locations - About 1 hr to fix
src/perf/java/rx/subscriptions/CompositeSubscriptionConcurrentPerf.java on lines 88..103
src/perf/java/rx/subscriptions/CompositeSubscriptionConcurrentPerf.java on lines 152..167

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 119.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    @Group("g4")
    @GroupThreads(1)
    @Benchmark
    public void addClearHalfT1() {
        CompositeSubscription csub = this.csub;
Severity: Major
Found in src/perf/java/rx/subscriptions/CompositeSubscriptionConcurrentPerf.java and 1 other location - About 1 hr to fix
src/perf/java/rx/subscriptions/SubscriptionListConcurrentPerf.java on lines 101..115

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 99.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @Group("g4")
    @GroupThreads(1)
    @Benchmark
    public void addClearHalfT2() {
        CompositeSubscription csub = this.csub;
Severity: Major
Found in src/perf/java/rx/subscriptions/CompositeSubscriptionConcurrentPerf.java and 1 other location - About 1 hr to fix
src/perf/java/rx/subscriptions/SubscriptionListConcurrentPerf.java on lines 116..130

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 99.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    @Group("g3")
    @GroupThreads(1)
    @Benchmark
    public void addClearT1() {
        CompositeSubscription csub = this.csub;
Severity: Major
Found in src/perf/java/rx/subscriptions/CompositeSubscriptionConcurrentPerf.java and 2 other locations - About 1 hr to fix
src/perf/java/rx/subscriptions/SubscriptionListConcurrentPerf.java on lines 73..86
src/perf/java/rx/subscriptions/SubscriptionListConcurrentPerf.java on lines 87..100

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 87.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    @Setup
    public void setup() {
        values = new Subscription[count * 2];
        for (int i = 0; i < count * 2; i++) {
            values[i] = new Subscription() {
Severity: Minor
Found in src/perf/java/rx/subscriptions/CompositeSubscriptionConcurrentPerf.java and 1 other location - About 55 mins to fix
src/perf/java/rx/subscriptions/SubscriptionListConcurrentPerf.java on lines 56..71

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status