Sign upLogin

ReactiveX/RxRuby

View on GitHub
Star

Showing 124 of 124 total issues

Method delay_with_selector has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    def delay_with_selector(subscription_delay, delay_duration_selector = nil)
      if Proc === subscription_delay
        selector = subscription_delay
      else
        sub_delay = subscription_delay
Severity: Minor
Found in lib/rx/linq/observable/delay_with_selector.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

module Rx

  module Observer

    class << self
Severity: Major
Found in lib/rx/core/synchronized_observer.rb and 1 other location - About 1 hr to fix
lib/rx/core/async_lock_observer.rb on lines 6..42

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method wait has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    def wait(&action)
      @gate.synchronize do
        @queue.push action unless @has_faulted

        if @is_acquired or @has_faulted
Severity: Minor
Found in lib/rx/concurrency/async_lock.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

module Rx

  module Observer

    class << self
Severity: Major
Found in lib/rx/core/async_lock_observer.rb and 1 other location - About 1 hr to fix
lib/rx/core/synchronized_observer.rb on lines 6..43

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method amb has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def amb(second)
      AnonymousObservable.new do |observer|
        left_subscription = SingleAssignmentSubscription.new
        right_subscription = SingleAssignmentSubscription.new
        choice = :neither
Severity: Minor
Found in lib/rx/operators/multiple.rb - About 1 hr to fix

    Method latest has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def latest
      AnonymousObservable.new do |observer|
        gate = Monitor.new
        inner_subscription = SerialSubscription.new
        stopped = false
    Severity: Minor
    Found in lib/rx/operators/multiple.rb - About 1 hr to fix

      Method do has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def do(observer_or_on_next = nil, on_error_func = nil, on_completed_func = nil)
      if block_given?
        on_next_func = Proc.new
      elsif Proc === observer_or_on_next
        on_next_func = observer_or_on_next
      Severity: Minor
      Found in lib/rx/linq/observable/do.rb - About 1 hr to fix

        Method amb has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            def amb(second)
      AnonymousObservable.new do |observer|
        left_subscription = SingleAssignmentSubscription.new
        right_subscription = SingleAssignmentSubscription.new
        choice = :neither
        Severity: Minor
        Found in lib/rx/operators/multiple.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method extrema_by has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def extrema_by(is_min = false, &block)
      AnonymousObservable.new do |observer|
        has_value = false
        last_key = nil
        list = []
        Severity: Minor
        Found in lib/rx/operators/aggregates.rb - About 1 hr to fix

          Method sample has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              def sample(intervalOrSampler, scheduler = DefaultScheduler.instance, &recipe)
      sampler = if intervalOrSampler.is_a? Numeric
        Observable.interval(intervalOrSampler, scheduler)
      else
        intervalOrSampler
          Severity: Minor
          Found in lib/rx/linq/observable/sample.rb - About 1 hr to fix

            Method zip has 34 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                  def zip(*args, &result_selector)
        AnonymousObservable.new do |observer|
          result_selector ||= lambda {|*inner_args| inner_args }
          n = args.length
            Severity: Minor
            Found in lib/rx/operators/multiple.rb - About 1 hr to fix

              Method concat_map_observer has 34 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  def concat_map_observer(on_next, on_error, on_completed)
      AnonymousObservable.new do |observer|
        index = 0

        subscribe(
              Severity: Minor
              Found in lib/rx/linq/observable/concat_map_observer.rb - About 1 hr to fix

                Method debounce has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    def debounce(due_time, scheduler = DefaultScheduler.instance)
      AnonymousObservable.new do |observer|
        cancelable = SerialSubscription.new
        hasvalue = false
        value = nil
                Severity: Minor
                Found in lib/rx/linq/observable/debounce.rb - About 1 hr to fix

                  Method window_with_count has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      def window_with_count(count, skip)
      raise ArgumentError.new 'Count must be greater than zero' if count <= 0
      raise ArgumentError.new 'Skip must be greater than zero' if skip <= 0

      AnonymousObservable.new do |observer|
                  Severity: Minor
                  Found in lib/rx/operators/single.rb - About 1 hr to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            right_obs = Observer.configure do |o|
          o.on_next do |r|
            has_right = true
            right = r
                    Severity: Major
                    Found in lib/rx/operators/multiple.rb and 1 other location - About 1 hr to fix
                    lib/rx/operators/multiple.rb on lines 133..156

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 57.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            left_obs = Observer.configure do |o|
          o.on_next do |l|
            has_left = true
            left = l
                    Severity: Major
                    Found in lib/rx/operators/multiple.rb and 1 other location - About 1 hr to fix
                    lib/rx/operators/multiple.rb on lines 160..183

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 57.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Method take_last has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                    Open

                        def take_last(count, scheduler = CurrentThreadScheduler.instance)
      raise ArgumentError.new 'Count cannot be less than zero' if count < 0
      AnonymousObservable.new do |observer|
        q = []
        g = CompositeSubscription.new
                    Severity: Minor
                    Found in lib/rx/operators/single.rb - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method single has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                    Open

                        def single(&block)
      return select(&block).single if block_given?
      AnonymousObservable.new do |observer|
        seen_value = false
        value = nil
                    Severity: Minor
                    Found in lib/rx/operators/aggregates.rb - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method merge_all has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                    Open

                        def merge_all
      AnonymousObservable.new do |observer|
        gate = Monitor.new
        stopped = false
        m = SingleAssignmentSubscription.new
                    Severity: Minor
                    Found in lib/rx/operators/multiple.rb - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method distinct_until_changed has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                    Open

                        def distinct_until_changed(&key_selector)
      key_selector ||= lambda {|x| x}
      AnonymousObservable.new do |observer|
        current_key = nil
        has_current = nil
                    Severity: Minor
                    Found in lib/rx/operators/single.rb - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language