Sign upLogin

ReadyResponder/ReadyResponder

View on GitHub
Star
app/helpers/inspections_helper.rb

Summary

Maintainability
A
30 mins
Test Coverage
B
81%

Method has too many lines. [11/10]
Open

    def inspection_label_class(inspection)
      # The options are found in app/models/inspection.rb: STATUS_CHOICES
      return nil if inspection.status.blank?
      case inspection.status
      when 'Complete - Passed'
Severity: Minor
Found in app/helpers/inspections_helper.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Avoid too many return statements within this method.
Open

        return 'label label-default'
Severity: Major
Found in app/helpers/inspections_helper.rb - About 30 mins to fix

    Inconsistent indentation detected.
    Open

        def inspection_label_class(inspection)
      # The options are found in app/models/inspection.rb: STATUS_CHOICES
      return nil if inspection.status.blank?
      case inspection.status
      when 'Complete - Passed'
    Severity: Minor
    Found in app/helpers/inspections_helper.rb by rubocop

    This cops checks for inconsistent indentation.

    Example:

    class A
  def test
    puts 'hello'
     puts 'world'
  end
end

    Line is too long. [84/80]
    Open

        content_tag(:span, inspection.status, class: inspection_label_class(inspection))
    Severity: Minor
    Found in app/helpers/inspections_helper.rb by rubocop

    Keep a blank line before and after private.
    Open

      private
    Severity: Minor
    Found in app/helpers/inspections_helper.rb by rubocop

    Access modifiers should be surrounded by blank lines.

    Example:

    # bad
class Foo
  def bar; end
  private
  def baz; end
end

# good
class Foo
  def bar; end

  private

  def baz; end
end

    Missing magic comment # frozen_string_literal: true.
    Open

    module InspectionsHelper
    Severity: Minor
    Found in app/helpers/inspections_helper.rb by rubocop

    This cop is designed to help upgrade to Ruby 3.0. It will add the comment # frozen_string_literal: true to the top of files to enable frozen string literals. Frozen string literals may be default in Ruby 3.0. The comment will be added below a shebang and encoding comment. The frozen string literal comment is only valid in Ruby 2.3+.

    Example: EnforcedStyle: when_needed (default)

    # The `when_needed` style will add the frozen string literal comment
# to files only when the `TargetRubyVersion` is set to 2.3+.
# bad
module Foo
  # ...
end

# good
# frozen_string_literal: true

module Foo
  # ...
end

    Example: EnforcedStyle: always

    # The `always` style will always add the frozen string literal comment
# to a file, regardless of the Ruby version or if `freeze` or `<<` are
# called on a string literal.
# bad
module Bar
  # ...
end

# good
# frozen_string_literal: true

module Bar
  # ...
end

    Example: EnforcedStyle: never

    # The `never` will enforce that the frozen string literal comment does
# not exist in a file.
# bad
# frozen_string_literal: true

module Baz
  # ...
end

# good
module Baz
  # ...
end

    Missing top-level module documentation comment.
    Open

    module InspectionsHelper
    Severity: Minor
    Found in app/helpers/inspections_helper.rb by rubocop

    This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

    The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

    Example:

    # bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

    There are no issues that match your filters.

    Category
    Status