ReadyResponder/ReadyResponder

View on GitHub
app/helpers/requirements_helper.rb

Summary

Maintainability
A
0 mins
Test Coverage
B
83%

Missing magic comment # frozen_string_literal: true.
Open

module RequirementsHelper
Severity: Minor
Found in app/helpers/requirements_helper.rb by rubocop

This cop is designed to help upgrade to Ruby 3.0. It will add the comment # frozen_string_literal: true to the top of files to enable frozen string literals. Frozen string literals may be default in Ruby 3.0. The comment will be added below a shebang and encoding comment. The frozen string literal comment is only valid in Ruby 2.3+.

Example: EnforcedStyle: when_needed (default)

# The `when_needed` style will add the frozen string literal comment
# to files only when the `TargetRubyVersion` is set to 2.3+.
# bad
module Foo
  # ...
end

# good
# frozen_string_literal: true

module Foo
  # ...
end

Example: EnforcedStyle: always

# The `always` style will always add the frozen string literal comment
# to a file, regardless of the Ruby version or if `freeze` or `<<` are
# called on a string literal.
# bad
module Bar
  # ...
end

# good
# frozen_string_literal: true

module Bar
  # ...
end

Example: EnforcedStyle: never

# The `never` will enforce that the frozen string literal comment does
# not exist in a file.
# bad
# frozen_string_literal: true

module Baz
  # ...
end

# good
module Baz
  # ...
end

Redundant return detected.
Open

        return nil
Severity: Minor
Found in app/helpers/requirements_helper.rb by rubocop

This cop checks for redundant return expressions.

Example:

def test
  return something
end

def test
  one
  two
  three
  return something
end

It should be extended to handle methods whose body is if/else or a case expression with a default branch.

Inconsistent indentation detected.
Open

    def requirement_status_label_class(requirement_status)
      return nil if requirement_status.blank?
      color = requirement_status_color(requirement_status) || 'default'
      return "label label-#{color}"
    end
Severity: Minor
Found in app/helpers/requirements_helper.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Redundant return detected.
Open

        return 'warning'
Severity: Minor
Found in app/helpers/requirements_helper.rb by rubocop

This cop checks for redundant return expressions.

Example:

def test
  return something
end

def test
  one
  two
  three
  return something
end

It should be extended to handle methods whose body is if/else or a case expression with a default branch.

Redundant return detected.
Open

      return "label label-#{color}"
Severity: Minor
Found in app/helpers/requirements_helper.rb by rubocop

This cop checks for redundant return expressions.

Example:

def test
  return something
end

def test
  one
  two
  three
  return something
end

It should be extended to handle methods whose body is if/else or a case expression with a default branch.

Redundant return detected.
Open

      return 'default'
Severity: Minor
Found in app/helpers/requirements_helper.rb by rubocop

This cop checks for redundant return expressions.

Example:

def test
  return something
end

def test
  one
  two
  three
  return something
end

It should be extended to handle methods whose body is if/else or a case expression with a default branch.

Missing top-level module documentation comment.
Open

module RequirementsHelper
Severity: Minor
Found in app/helpers/requirements_helper.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Inconsistent indentation detected.
Open

    def requirement_status_color(requirement_status)
      # The options are found in app/models/requirement.rb: STATUS_CHOICES
      case requirement_status
      when 'Full', 'Satisfied'
        return 'success'
Severity: Minor
Found in app/helpers/requirements_helper.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Keep a blank line before and after private.
Open

  private
Severity: Minor
Found in app/helpers/requirements_helper.rb by rubocop

Access modifiers should be surrounded by blank lines.

Example:

# bad
class Foo
  def bar; end
  private
  def baz; end
end

# good
class Foo
  def bar; end

  private

  def baz; end
end

Inconsistent indentation detected.
Open

    def requirement_priority_label_class(requirement_priority)
      return nil if requirement_priority.blank?
      color = requirement_priority_color(requirement_priority) || 'default'
      return "label label-#{color}"
    end
Severity: Minor
Found in app/helpers/requirements_helper.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Redundant return detected.
Open

      return "label label-#{color}"
Severity: Minor
Found in app/helpers/requirements_helper.rb by rubocop

This cop checks for redundant return expressions.

Example:

def test
  return something
end

def test
  one
  two
  three
  return something
end

It should be extended to handle methods whose body is if/else or a case expression with a default branch.

Line is too long. [101/80]
Open

    content_tag(:span, requirement.status, class: requirement_status_label_class(requirement.status))
Severity: Minor
Found in app/helpers/requirements_helper.rb by rubocop

Inconsistent indentation detected.
Open

    def requirement_priority_color(requirement_priority)
      return 'default'
    end
Severity: Minor
Found in app/helpers/requirements_helper.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Unused method argument - requirement_priority. If it's necessary, use _ or _requirement_priority as an argument name to indicate that it won't be used. You can also write as requirement_priority_color(*) if you want the method to accept any arguments but don't care about them.
Open

    def requirement_priority_color(requirement_priority)
Severity: Minor
Found in app/helpers/requirements_helper.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

There are no issues that match your filters.

Category
Status