Sign upLogin

ReadyResponder/ReadyResponder

View on GitHub
Star
app/helpers/tasks_helper.rb

Summary

Maintainability
A
0 mins
Test Coverage
B
85%

Assignment Branch Condition size for task_address is too high. [16.25/15]
Open

  def task_address
    comma = if @task.city.present? && @task.state.present?
              ', '
            else
              ''
Severity: Minor
Found in app/helpers/tasks_helper.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Redundant return detected.
Open

      return "label label-#{color}"
Severity: Minor
Found in app/helpers/tasks_helper.rb by rubocop

This cop checks for redundant return expressions.

Example:

def test
  return something
end

def test
  one
  two
  three
  return something
end

It should be extended to handle methods whose body is if/else or a case expression with a default branch.

Use 2 (not 0) spaces for indenting an expression spanning multiple lines.
Open

    @task.longitude.present?
Severity: Minor
Found in app/helpers/tasks_helper.rb by rubocop

This cop checks the indentation of the right hand side operand in binary operations that span more than one line.

Example:

# bad
if a +
b
  something
end

# good
if a +
   b
  something
end

Inconsistent indentation detected.
Open

    def task_priority_label_class(task_priority)
      return nil if task_priority.blank?
      color = task_priority_color(task_priority) || 'default'
      return "label label-#{color}"
    end
Severity: Minor
Found in app/helpers/tasks_helper.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Keep a blank line before and after private.
Open

  private
Severity: Minor
Found in app/helpers/tasks_helper.rb by rubocop

Access modifiers should be surrounded by blank lines.

Example:

# bad
class Foo
  def bar; end
  private
  def baz; end
end

# good
class Foo
  def bar; end

  private

  def baz; end
end

Rename has_latitude_longitude? to latitude_longitude?.
Open

  def has_latitude_longitude?
Severity: Minor
Found in app/helpers/tasks_helper.rb by rubocop

This cop makes sure that predicates are named properly.

Example:

# bad
def is_even?(value)
end

# good
def even?(value)
end

# bad
def has_value?
end

# good
def value?
end

Redundant return detected.
Open

        return nil
Severity: Minor
Found in app/helpers/tasks_helper.rb by rubocop

This cop checks for redundant return expressions.

Example:

def test
  return something
end

def test
  one
  two
  three
  return something
end

It should be extended to handle methods whose body is if/else or a case expression with a default branch.

Inconsistent indentation detected.
Open

    def task_priority_color(task_priority)
      return 'default'
    end
Severity: Minor
Found in app/helpers/tasks_helper.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Line is too long. [89/80]
Open

    content_tag(:span, task.staffing_level, class: task_label_class(task.staffing_level))
Severity: Minor
Found in app/helpers/tasks_helper.rb by rubocop

Use && instead of and.
Open

    @task.latitude.present? and
Severity: Minor
Found in app/helpers/tasks_helper.rb by rubocop

This cop checks for uses of and and or, and suggests using && and || instead. It can be configured to check only in conditions, or in all contexts.

Example: EnforcedStyle: always (default)

# bad
foo.save and return

# bad
if foo and bar
end

# good
foo.save && return

# good
if foo && bar
end

Example: EnforcedStyle: conditionals

# bad
if foo and bar
end

# good
foo.save && return

# good
foo.save and return

# good
if foo && bar
end

Redundant return detected.
Open

      return 'default'
Severity: Minor
Found in app/helpers/tasks_helper.rb by rubocop

This cop checks for redundant return expressions.

Example:

def test
  return something
end

def test
  one
  two
  three
  return something
end

It should be extended to handle methods whose body is if/else or a case expression with a default branch.

Unused method argument - task_priority. If it's necessary, use _ or _task_priority as an argument name to indicate that it won't be used. You can also write as task_priority_color(*) if you want the method to accept any arguments but don't care about them.
Open

    def task_priority_color(task_priority)
Severity: Minor
Found in app/helpers/tasks_helper.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

Redundant return detected.
Open

      return "label label-#{color}"
Severity: Minor
Found in app/helpers/tasks_helper.rb by rubocop

This cop checks for redundant return expressions.

Example:

def test
  return something
end

def test
  one
  two
  three
  return something
end

It should be extended to handle methods whose body is if/else or a case expression with a default branch.

Inconsistent indentation detected.
Open

    def task_label_class(task_status)
      return nil if task_status.blank?
      color = task_status_color(task_status) || 'default'
      return "label label-#{color}"
    end
Severity: Minor
Found in app/helpers/tasks_helper.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Missing top-level module documentation comment.
Open

module TasksHelper
Severity: Minor
Found in app/helpers/tasks_helper.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Missing magic comment # frozen_string_literal: true.
Open

module TasksHelper
Severity: Minor
Found in app/helpers/tasks_helper.rb by rubocop

This cop is designed to help upgrade to Ruby 3.0. It will add the comment # frozen_string_literal: true to the top of files to enable frozen string literals. Frozen string literals may be default in Ruby 3.0. The comment will be added below a shebang and encoding comment. The frozen string literal comment is only valid in Ruby 2.3+.

Example: EnforcedStyle: when_needed (default)

# The `when_needed` style will add the frozen string literal comment
# to files only when the `TargetRubyVersion` is set to 2.3+.
# bad
module Foo
  # ...
end

# good
# frozen_string_literal: true

module Foo
  # ...
end

Example: EnforcedStyle: always

# The `always` style will always add the frozen string literal comment
# to a file, regardless of the Ruby version or if `freeze` or `<<` are
# called on a string literal.
# bad
module Bar
  # ...
end

# good
# frozen_string_literal: true

module Bar
  # ...
end

Example: EnforcedStyle: never

# The `never` will enforce that the frozen string literal comment does
# not exist in a file.
# bad
# frozen_string_literal: true

module Baz
  # ...
end

# good
module Baz
  # ...
end

Inconsistent indentation detected.
Open

    def task_status_color(task_status)
      # The options are found in app/models/task.rb: STATUS_CHOICES
      case task_status
      when 'Full', 'Satisfied'
        return 'success'
Severity: Minor
Found in app/helpers/tasks_helper.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Redundant return detected.
Open

        return 'warning'
Severity: Minor
Found in app/helpers/tasks_helper.rb by rubocop

This cop checks for redundant return expressions.

Example:

def test
  return something
end

def test
  one
  two
  three
  return something
end

It should be extended to handle methods whose body is if/else or a case expression with a default branch.

There are no issues that match your filters.

Category
Status