ReadyResponder/ReadyResponder

View on GitHub
app/services/availability_creator.rb

Summary

Maintainability
A
25 mins
Test Coverage
A
94%

Assignment Branch Condition size for process_overlapping is too high. [19.21/15]
Open

  def process_overlapping
    partially_overlapping_availabilities.each do |a|
      if a.status == status
        @availability.start_time = [a.start_time, @availability.start_time].min
        @availability.end_time   = [a.end_time, @availability.end_time].max

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method has too many lines. [13/10]
Open

  def process_overlapping
    partially_overlapping_availabilities.each do |a|
      if a.status == status
        @availability.start_time = [a.start_time, @availability.start_time].min
        @availability.end_time   = [a.end_time, @availability.end_time].max

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method call has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def call
    @availability.transaction do
      process_containing  if containing_availabilities.any?
      process_contained   if contained_availabilities.any?
      process_overlapping if partially_overlapping_availabilities.any?
Severity: Minor
Found in app/services/availability_creator.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Pass &:cancel! as an argument to each instead of a block.
Open

    contained_availabilities.each { |a| a.cancel! }

Use symbols as procs when possible.

Example:

# bad
something.map { |s| s.upcase }

# good
something.map(&:upcase)

Line is too long. [94/80]
Open

        'A longer availability with the same status covering the given period already exists.'

Align the parameters of a method call if they span more than one line.
Open

        'A longer availability with the same status covering the given period already exists.'

Here we check if the parameters on a multi-line method call or definition are aligned.

Example: EnforcedStyle: withfirstparameter (default)

# good

foo :bar,
    :baz

# bad

foo :bar,
  :baz

Example: EnforcedStyle: withfixedindentation

# good

foo :bar,
  :baz

# bad

foo :bar,
    :baz

Convert if nested inside else to elsif.
Open

        if a.start_time > start_time

If the else branch of a conditional consists solely of an if node, it can be combined with the else to become an elsif. This helps to keep the nesting level from getting too deep.

Example:

# bad
if condition_a
  action_a
else
  if condition_b
    action_b
  else
    action_c
  end
end

# good
if condition_a
  action_a
elsif condition_b
  action_b
else
  action_c
end

Trailing whitespace detected.
Open

    

Missing magic comment # frozen_string_literal: true.
Open

class AvailabilityCreator

This cop is designed to help upgrade to Ruby 3.0. It will add the comment # frozen_string_literal: true to the top of files to enable frozen string literals. Frozen string literals may be default in Ruby 3.0. The comment will be added below a shebang and encoding comment. The frozen string literal comment is only valid in Ruby 2.3+.

Example: EnforcedStyle: when_needed (default)

# The `when_needed` style will add the frozen string literal comment
# to files only when the `TargetRubyVersion` is set to 2.3+.
# bad
module Foo
  # ...
end

# good
# frozen_string_literal: true

module Foo
  # ...
end

Example: EnforcedStyle: always

# The `always` style will always add the frozen string literal comment
# to a file, regardless of the Ruby version or if `freeze` or `<<` are
# called on a string literal.
# bad
module Bar
  # ...
end

# good
# frozen_string_literal: true

module Bar
  # ...
end

Example: EnforcedStyle: never

# The `never` will enforce that the frozen string literal comment does
# not exist in a file.
# bad
# frozen_string_literal: true

module Baz
  # ...
end

# good
module Baz
  # ...
end

Align the parameters of a method call if they span more than one line.
Open

      new_end_time: start_time, new_start_time: end_time)

Here we check if the parameters on a multi-line method call or definition are aligned.

Example: EnforcedStyle: withfirstparameter (default)

# good

foo :bar,
    :baz

# bad

foo :bar,
  :baz

Example: EnforcedStyle: withfixedindentation

# good

foo :bar,
  :baz

# bad

foo :bar,
    :baz

Missing top-level class documentation comment.
Open

class AvailabilityCreator

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Trailing whitespace detected.
Open

  # This method assumes that a person cannot have active and 

Trailing whitespace detected.
Open

  

There are no issues that match your filters.

Category
Status