Sign upLogin

ReadyResponder/ReadyResponder

View on GitHub
Star
spec/features/events/event_page_spec.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Block has too many lines. [168/25]
Open

RSpec.feature 'Event page' do
  context 'logged in as an Editor and given an event with departments and rank' do
    before(:each) do
      sign_in_as('Editor')
    end
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Block has too many lines. [166/25]
Open

  context 'logged in as an Editor and given an event with departments and rank' do
    before(:each) do
      sign_in_as('Editor')
    end
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Block has too many lines. [135/25]
Open

    context 'given an event with associated departments where members have differing availabilities' do
      before(:each) do
        Timecop.freeze

        # Set up the event with multiple departments
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Block has too many lines. [28/25]
Open

      scenario 'shows assigned people by department' do
        task  = create(:task, event: @event)
        title = create(:title)
        requirement = create(:requirement, task: task, title: title)
        different_event = create(:event, departments: [@response_team, @medical_reserve],
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      scenario 'shows unavailable people by department' do
        unavailable_doc = create(:person, department: @medical_reserve)
        person_from_different_dept = create(:person, department: @division_group)
        create(:availability, person: unavailable_doc, status: 'Unavailable',
               start_time: @event.start_time, end_time: @event.end_time)
Severity: Major
Found in spec/features/events/event_page_spec.rb and 1 other location - About 3 hrs to fix
spec/features/events/event_page_spec.rb on lines 98..121

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 131.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      scenario 'shows available people by department' do
        available_doc = create(:person, department: @medical_reserve)
        person_from_different_dept = create(:person, department: @division_group)
        create(:availability, person: available_doc, status: 'Available',
               start_time: @event.start_time, end_time: @event.end_time)
Severity: Major
Found in spec/features/events/event_page_spec.rb and 1 other location - About 3 hrs to fix
spec/features/events/event_page_spec.rb on lines 151..174

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 131.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Align the elements of a hash literal if they span more than one line.
Open

                                    title_order: 1)
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Check that the keys, separators, and values of a multi-line hash literal are aligned according to configuration. The configuration options are:

- key (left align keys)
- separator (align hash rockets and colons, right align keys)
- table (left align keys, hash rockets, and values)

The treatment of hashes passed as the last argument to a method call can also be configured. The options are:

- always_inspect
- always_ignore
- ignore_implicit (without curly braces)
- ignore_explicit (with curly braces)

Example:

# EnforcedHashRocketStyle: key (default)
# EnforcedColonStyle: key (default)

# good
{
  foo: bar,
  ba: baz
}
{
  :foo => bar,
  :ba => baz
}

# bad
{
  foo: bar,
   ba: baz
}
{
  :foo => bar,
   :ba => baz
}

Example:

# EnforcedHashRocketStyle: separator
# EnforcedColonStyle: separator

#good
{
  foo: bar,
   ba: baz
}
{
  :foo => bar,
   :ba => baz
}

#bad
{
  foo: bar,
  ba: baz
}
{
  :foo => bar,
  :ba => baz
}
{
  :foo => bar,
  :ba  => baz
}

Example:

# EnforcedHashRocketStyle: table
# EnforcedColonStyle: table

#good
{
  foo: bar,
  ba:  baz
}
{
  :foo => bar,
  :ba  => baz
}

#bad
{
  foo: bar,
  ba: baz
}
{
  :foo => bar,
   :ba => baz
}

Line is too long. [81/80]
Open

          expect(page).to have_css('.event-labels[title="Available"]', text: '1')
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Line is too long. [86/80]
Open

        create(:availability, person: person_from_different_dept, status: 'Available',
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Line is too long. [87/80]
Open

        within("table#event-status tr##{@medical_reserve.name.parameterize}-status") do
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Align the elements of a hash literal if they span more than one line.
Open

               start_time: @event.start_time, end_time: @event.end_time)
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Check that the keys, separators, and values of a multi-line hash literal are aligned according to configuration. The configuration options are:

- key (left align keys)
- separator (align hash rockets and colons, right align keys)
- table (left align keys, hash rockets, and values)

The treatment of hashes passed as the last argument to a method call can also be configured. The options are:

- always_inspect
- always_ignore
- ignore_implicit (without curly braces)
- ignore_explicit (with curly braces)

Example:

# EnforcedHashRocketStyle: key (default)
# EnforcedColonStyle: key (default)

# good
{
  foo: bar,
  ba: baz
}
{
  :foo => bar,
  :ba => baz
}

# bad
{
  foo: bar,
   ba: baz
}
{
  :foo => bar,
   :ba => baz
}

Example:

# EnforcedHashRocketStyle: separator
# EnforcedColonStyle: separator

#good
{
  foo: bar,
   ba: baz
}
{
  :foo => bar,
   :ba => baz
}

#bad
{
  foo: bar,
  ba: baz
}
{
  :foo => bar,
  :ba => baz
}
{
  :foo => bar,
  :ba  => baz
}

Example:

# EnforcedHashRocketStyle: table
# EnforcedColonStyle: table

#good
{
  foo: bar,
  ba:  baz
}
{
  :foo => bar,
  :ba  => baz
}

#bad
{
  foo: bar,
  ba: baz
}
{
  :foo => bar,
   :ba => baz
}

Line is too long. [94/80]
Open

          expect(page).to have_css('.event-labels[title="Assigned to THIS Event"]', text: '0')
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Line is too long. [88/80]
Open

               start_time: @event.start_time + 1.day, end_time: @event.end_time + 1.day)
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Line is too long. [81/80]
Open

          expect(page).to have_css('.event-labels[title="Available"]', text: '0')
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Align the elements of a hash literal if they span more than one line.
Open

                        departments: @departments)
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Check that the keys, separators, and values of a multi-line hash literal are aligned according to configuration. The configuration options are:

- key (left align keys)
- separator (align hash rockets and colons, right align keys)
- table (left align keys, hash rockets, and values)

The treatment of hashes passed as the last argument to a method call can also be configured. The options are:

- always_inspect
- always_ignore
- ignore_implicit (without curly braces)
- ignore_explicit (with curly braces)

Example:

# EnforcedHashRocketStyle: key (default)
# EnforcedColonStyle: key (default)

# good
{
  foo: bar,
  ba: baz
}
{
  :foo => bar,
  :ba => baz
}

# bad
{
  foo: bar,
   ba: baz
}
{
  :foo => bar,
   :ba => baz
}

Example:

# EnforcedHashRocketStyle: separator
# EnforcedColonStyle: separator

#good
{
  foo: bar,
   ba: baz
}
{
  :foo => bar,
   :ba => baz
}

#bad
{
  foo: bar,
  ba: baz
}
{
  :foo => bar,
  :ba => baz
}
{
  :foo => bar,
  :ba  => baz
}

Example:

# EnforcedHashRocketStyle: table
# EnforcedColonStyle: table

#good
{
  foo: bar,
  ba:  baz
}
{
  :foo => bar,
  :ba  => baz
}

#bad
{
  foo: bar,
  ba: baz
}
{
  :foo => bar,
   :ba => baz
}

Align the elements of a hash literal if they span more than one line.
Open

               start_time: @event.start_time + 1.day, end_time: @event.end_time + 1.day)
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Check that the keys, separators, and values of a multi-line hash literal are aligned according to configuration. The configuration options are:

- key (left align keys)
- separator (align hash rockets and colons, right align keys)
- table (left align keys, hash rockets, and values)

The treatment of hashes passed as the last argument to a method call can also be configured. The options are:

- always_inspect
- always_ignore
- ignore_implicit (without curly braces)
- ignore_explicit (with curly braces)

Example:

# EnforcedHashRocketStyle: key (default)
# EnforcedColonStyle: key (default)

# good
{
  foo: bar,
  ba: baz
}
{
  :foo => bar,
  :ba => baz
}

# bad
{
  foo: bar,
   ba: baz
}
{
  :foo => bar,
   :ba => baz
}

Example:

# EnforcedHashRocketStyle: separator
# EnforcedColonStyle: separator

#good
{
  foo: bar,
   ba: baz
}
{
  :foo => bar,
   :ba => baz
}

#bad
{
  foo: bar,
  ba: baz
}
{
  :foo => bar,
  :ba => baz
}
{
  :foo => bar,
  :ba  => baz
}

Example:

# EnforcedHashRocketStyle: table
# EnforcedColonStyle: table

#good
{
  foo: bar,
  ba:  baz
}
{
  :foo => bar,
  :ba  => baz
}

#bad
{
  foo: bar,
  ba: baz
}
{
  :foo => bar,
   :ba => baz
}

Line is too long. [83/80]
Open

          expect(page).to have_css('.event-labels[title="Unavailable"]', text: '0')
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Line is too long. [81/80]
Open

        person_from_different_dept = create(:person, department: @division_group)
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Line is too long. [85/80]
Open

        within("table#event-status tr##{@response_team.name.parameterize}-status") do
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Align the elements of a hash literal if they span more than one line.
Open

                        start_time: 1.day.from_now, end_time: 3.days.from_now,
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Check that the keys, separators, and values of a multi-line hash literal are aligned according to configuration. The configuration options are:

- key (left align keys)
- separator (align hash rockets and colons, right align keys)
- table (left align keys, hash rockets, and values)

The treatment of hashes passed as the last argument to a method call can also be configured. The options are:

- always_inspect
- always_ignore
- ignore_implicit (without curly braces)
- ignore_explicit (with curly braces)

Example:

# EnforcedHashRocketStyle: key (default)
# EnforcedColonStyle: key (default)

# good
{
  foo: bar,
  ba: baz
}
{
  :foo => bar,
  :ba => baz
}

# bad
{
  foo: bar,
   ba: baz
}
{
  :foo => bar,
   :ba => baz
}

Example:

# EnforcedHashRocketStyle: separator
# EnforcedColonStyle: separator

#good
{
  foo: bar,
   ba: baz
}
{
  :foo => bar,
   :ba => baz
}

#bad
{
  foo: bar,
  ba: baz
}
{
  :foo => bar,
  :ba => baz
}
{
  :foo => bar,
  :ba  => baz
}

Example:

# EnforcedHashRocketStyle: table
# EnforcedColonStyle: table

#good
{
  foo: bar,
  ba:  baz
}
{
  :foo => bar,
  :ba  => baz
}

#bad
{
  foo: bar,
  ba: baz
}
{
  :foo => bar,
   :ba => baz
}

Align the elements of a hash literal if they span more than one line.
Open

               start_time: @event.start_time, end_time: @event.end_time)
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Check that the keys, separators, and values of a multi-line hash literal are aligned according to configuration. The configuration options are:

- key (left align keys)
- separator (align hash rockets and colons, right align keys)
- table (left align keys, hash rockets, and values)

The treatment of hashes passed as the last argument to a method call can also be configured. The options are:

- always_inspect
- always_ignore
- ignore_implicit (without curly braces)
- ignore_explicit (with curly braces)

Example:

# EnforcedHashRocketStyle: key (default)
# EnforcedColonStyle: key (default)

# good
{
  foo: bar,
  ba: baz
}
{
  :foo => bar,
  :ba => baz
}

# bad
{
  foo: bar,
   ba: baz
}
{
  :foo => bar,
   :ba => baz
}

Example:

# EnforcedHashRocketStyle: separator
# EnforcedColonStyle: separator

#good
{
  foo: bar,
   ba: baz
}
{
  :foo => bar,
   :ba => baz
}

#bad
{
  foo: bar,
  ba: baz
}
{
  :foo => bar,
  :ba => baz
}
{
  :foo => bar,
  :ba  => baz
}

Example:

# EnforcedHashRocketStyle: table
# EnforcedColonStyle: table

#good
{
  foo: bar,
  ba:  baz
}
{
  :foo => bar,
  :ba  => baz
}

#bad
{
  foo: bar,
  ba: baz
}
{
  :foo => bar,
   :ba => baz
}

Line is too long. [83/80]
Open

          expect(page).to have_css('.event-labels[title="No Response"]', text: '1')
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Line is too long. [81/80]
Open

          expect(page).to have_css('.event-labels[title="Available"]', text: '0')
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Line is too long. [81/80]
Open

        person_from_different_dept = create(:person, department: @division_group)
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Line is too long. [94/80]
Open

          expect(page).to have_css('.event-labels[title="Assigned to THIS Event"]', text: '1')
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Align the elements of a hash literal if they span more than one line.
Open

                        start_time: 2.day.from_now, end_time: 4.days.from_now,
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Check that the keys, separators, and values of a multi-line hash literal are aligned according to configuration. The configuration options are:

- key (left align keys)
- separator (align hash rockets and colons, right align keys)
- table (left align keys, hash rockets, and values)

The treatment of hashes passed as the last argument to a method call can also be configured. The options are:

- always_inspect
- always_ignore
- ignore_implicit (without curly braces)
- ignore_explicit (with curly braces)

Example:

# EnforcedHashRocketStyle: key (default)
# EnforcedColonStyle: key (default)

# good
{
  foo: bar,
  ba: baz
}
{
  :foo => bar,
  :ba => baz
}

# bad
{
  foo: bar,
   ba: baz
}
{
  :foo => bar,
   :ba => baz
}

Example:

# EnforcedHashRocketStyle: separator
# EnforcedColonStyle: separator

#good
{
  foo: bar,
   ba: baz
}
{
  :foo => bar,
   :ba => baz
}

#bad
{
  foo: bar,
  ba: baz
}
{
  :foo => bar,
  :ba => baz
}
{
  :foo => bar,
  :ba  => baz
}

Example:

# EnforcedHashRocketStyle: table
# EnforcedColonStyle: table

#good
{
  foo: bar,
  ba:  baz
}
{
  :foo => bar,
  :ba  => baz
}

#bad
{
  foo: bar,
  ba: baz
}
{
  :foo => bar,
   :ba => baz
}

Align the elements of a hash literal if they span more than one line.
Open

               start_time: @event.start_time, end_time: @event.end_time)
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Check that the keys, separators, and values of a multi-line hash literal are aligned according to configuration. The configuration options are:

- key (left align keys)
- separator (align hash rockets and colons, right align keys)
- table (left align keys, hash rockets, and values)

The treatment of hashes passed as the last argument to a method call can also be configured. The options are:

- always_inspect
- always_ignore
- ignore_implicit (without curly braces)
- ignore_explicit (with curly braces)

Example:

# EnforcedHashRocketStyle: key (default)
# EnforcedColonStyle: key (default)

# good
{
  foo: bar,
  ba: baz
}
{
  :foo => bar,
  :ba => baz
}

# bad
{
  foo: bar,
   ba: baz
}
{
  :foo => bar,
   :ba => baz
}

Example:

# EnforcedHashRocketStyle: separator
# EnforcedColonStyle: separator

#good
{
  foo: bar,
   ba: baz
}
{
  :foo => bar,
   :ba => baz
}

#bad
{
  foo: bar,
  ba: baz
}
{
  :foo => bar,
  :ba => baz
}
{
  :foo => bar,
  :ba  => baz
}

Example:

# EnforcedHashRocketStyle: table
# EnforcedColonStyle: table

#good
{
  foo: bar,
  ba:  baz
}
{
  :foo => bar,
  :ba  => baz
}

#bad
{
  foo: bar,
  ba: baz
}
{
  :foo => bar,
   :ba => baz
}

Line is too long. [85/80]
Open

        within("table#event-status tr##{@response_team.name.parameterize}-status") do
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Line is too long. [81/80]
Open

        create(:assignment, requirement: requirement, person: assigned_responder)
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Line is too long. [91/80]
Open

          expect(page).to have_css('.event-labels[title="Partially Available"]', text: '0')
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Line is too long. [82/80]
Open

        create(:availability, person: partially_av_responder, status: 'Available',
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Line is too long. [87/80]
Open

        within("table#event-status tr##{@medical_reserve.name.parameterize}-status") do
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Line is too long. [94/80]
Open

          expect(page).to have_css('.event-labels[title="Assigned to THIS Event"]', text: '0')
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Line is too long. [83/80]
Open

          expect(page).to have_css('.event-labels[title="No Response"]', text: '0')
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Line is too long. [81/80]
Open

        person_from_different_dept = create(:person, department: @division_group)
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Line is too long. [87/80]
Open

        within("table#event-status tr##{@medical_reserve.name.parameterize}-status") do
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Align the elements of a hash literal if they span more than one line.
Open

                        min_title: Person::TITLE_ORDER.keys.last)
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Check that the keys, separators, and values of a multi-line hash literal are aligned according to configuration. The configuration options are:

- key (left align keys)
- separator (align hash rockets and colons, right align keys)
- table (left align keys, hash rockets, and values)

The treatment of hashes passed as the last argument to a method call can also be configured. The options are:

- always_inspect
- always_ignore
- ignore_implicit (without curly braces)
- ignore_explicit (with curly braces)

Example:

# EnforcedHashRocketStyle: key (default)
# EnforcedColonStyle: key (default)

# good
{
  foo: bar,
  ba: baz
}
{
  :foo => bar,
  :ba => baz
}

# bad
{
  foo: bar,
   ba: baz
}
{
  :foo => bar,
   :ba => baz
}

Example:

# EnforcedHashRocketStyle: separator
# EnforcedColonStyle: separator

#good
{
  foo: bar,
   ba: baz
}
{
  :foo => bar,
   :ba => baz
}

#bad
{
  foo: bar,
  ba: baz
}
{
  :foo => bar,
  :ba => baz
}
{
  :foo => bar,
  :ba  => baz
}

Example:

# EnforcedHashRocketStyle: table
# EnforcedColonStyle: table

#good
{
  foo: bar,
  ba:  baz
}
{
  :foo => bar,
  :ba  => baz
}

#bad
{
  foo: bar,
  ba: baz
}
{
  :foo => bar,
   :ba => baz
}

Line is too long. [87/80]
Open

        within("table#event-status tr##{@medical_reserve.name.parameterize}-status") do
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Line is too long. [85/80]
Open

        within("table#event-status tr##{@response_team.name.parameterize}-status") do
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Line is too long. [94/80]
Open

          expect(page).to have_css('.event-labels[title="Assigned to THIS Event"]', text: '0')
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Align the elements of a hash literal if they span more than one line.
Open

               start_time: @event.start_time + 1.day, end_time: @event.end_time + 1.day)
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Check that the keys, separators, and values of a multi-line hash literal are aligned according to configuration. The configuration options are:

- key (left align keys)
- separator (align hash rockets and colons, right align keys)
- table (left align keys, hash rockets, and values)

The treatment of hashes passed as the last argument to a method call can also be configured. The options are:

- always_inspect
- always_ignore
- ignore_implicit (without curly braces)
- ignore_explicit (with curly braces)

Example:

# EnforcedHashRocketStyle: key (default)
# EnforcedColonStyle: key (default)

# good
{
  foo: bar,
  ba: baz
}
{
  :foo => bar,
  :ba => baz
}

# bad
{
  foo: bar,
   ba: baz
}
{
  :foo => bar,
   :ba => baz
}

Example:

# EnforcedHashRocketStyle: separator
# EnforcedColonStyle: separator

#good
{
  foo: bar,
   ba: baz
}
{
  :foo => bar,
   :ba => baz
}

#bad
{
  foo: bar,
  ba: baz
}
{
  :foo => bar,
  :ba => baz
}
{
  :foo => bar,
  :ba  => baz
}

Example:

# EnforcedHashRocketStyle: table
# EnforcedColonStyle: table

#good
{
  foo: bar,
  ba:  baz
}
{
  :foo => bar,
  :ba  => baz
}

#bad
{
  foo: bar,
  ba: baz
}
{
  :foo => bar,
   :ba => baz
}

Line is too long. [81/80]
Open

          expect(page).to have_css('.event-labels[title="Available"]', text: '0')
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Align the elements of a hash literal if they span more than one line.
Open

                        min_title: Person::TITLE_ORDER.keys.last)
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Check that the keys, separators, and values of a multi-line hash literal are aligned according to configuration. The configuration options are:

- key (left align keys)
- separator (align hash rockets and colons, right align keys)
- table (left align keys, hash rockets, and values)

The treatment of hashes passed as the last argument to a method call can also be configured. The options are:

- always_inspect
- always_ignore
- ignore_implicit (without curly braces)
- ignore_explicit (with curly braces)

Example:

# EnforcedHashRocketStyle: key (default)
# EnforcedColonStyle: key (default)

# good
{
  foo: bar,
  ba: baz
}
{
  :foo => bar,
  :ba => baz
}

# bad
{
  foo: bar,
   ba: baz
}
{
  :foo => bar,
   :ba => baz
}

Example:

# EnforcedHashRocketStyle: separator
# EnforcedColonStyle: separator

#good
{
  foo: bar,
   ba: baz
}
{
  :foo => bar,
   :ba => baz
}

#bad
{
  foo: bar,
  ba: baz
}
{
  :foo => bar,
  :ba => baz
}
{
  :foo => bar,
  :ba  => baz
}

Example:

# EnforcedHashRocketStyle: table
# EnforcedColonStyle: table

#good
{
  foo: bar,
  ba:  baz
}
{
  :foo => bar,
  :ba  => baz
}

#bad
{
  foo: bar,
  ba: baz
}
{
  :foo => bar,
   :ba => baz
}

Line is too long. [88/80]
Open

               start_time: @event.start_time + 1.day, end_time: @event.end_time + 1.day)
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Line is too long. [91/80]
Open

          expect(page).to have_css('.event-labels[title="Partially Available"]', text: '0')
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Line is too long. [83/80]
Open

          expect(page).to have_css('.event-labels[title="Unavailable"]', text: '0')
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Align the elements of a hash literal if they span more than one line.
Open

               start_time: @event.start_time, end_time: @event.end_time)
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Check that the keys, separators, and values of a multi-line hash literal are aligned according to configuration. The configuration options are:

- key (left align keys)
- separator (align hash rockets and colons, right align keys)
- table (left align keys, hash rockets, and values)

The treatment of hashes passed as the last argument to a method call can also be configured. The options are:

- always_inspect
- always_ignore
- ignore_implicit (without curly braces)
- ignore_explicit (with curly braces)

Example:

# EnforcedHashRocketStyle: key (default)
# EnforcedColonStyle: key (default)

# good
{
  foo: bar,
  ba: baz
}
{
  :foo => bar,
  :ba => baz
}

# bad
{
  foo: bar,
   ba: baz
}
{
  :foo => bar,
   :ba => baz
}

Example:

# EnforcedHashRocketStyle: separator
# EnforcedColonStyle: separator

#good
{
  foo: bar,
   ba: baz
}
{
  :foo => bar,
   :ba => baz
}

#bad
{
  foo: bar,
  ba: baz
}
{
  :foo => bar,
  :ba => baz
}
{
  :foo => bar,
  :ba  => baz
}

Example:

# EnforcedHashRocketStyle: table
# EnforcedColonStyle: table

#good
{
  foo: bar,
  ba:  baz
}
{
  :foo => bar,
  :ba  => baz
}

#bad
{
  foo: bar,
  ba: baz
}
{
  :foo => bar,
   :ba => baz
}

Line is too long. [82/80]
Open

  context 'logged in as an Editor and given an event with departments and rank' do
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Line is too long. [103/80]
Open

    context 'given an event with associated departments where members have differing availabilities' do
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Line is too long. [83/80]
Open

          expect(page).to have_css('.event-labels[title="No Response"]', text: '0')
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Line is too long. [83/80]
Open

          expect(page).to have_css('.event-labels[title="No Response"]', text: '0')
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Line is too long. [89/80]
Open

        different_event = create(:event, departments: [@response_team, @medical_reserve],
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Line is too long. [81/80]
Open

          expect(page).to have_css('.event-labels[title="Available"]', text: '0')
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Line is too long. [98/80]
Open

          expect(page).not_to have_css('.event-labels[title="Assigned to THIS Event"]', text: '1')
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Line is too long. [91/80]
Open

          expect(page).to have_css('.event-labels[title="Partially Available"]', text: '1')
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Align the elements of a hash literal if they span more than one line.
Open

                        start_time: 1.day.ago, end_time: 1.day.from_now,
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Check that the keys, separators, and values of a multi-line hash literal are aligned according to configuration. The configuration options are:

- key (left align keys)
- separator (align hash rockets and colons, right align keys)
- table (left align keys, hash rockets, and values)

The treatment of hashes passed as the last argument to a method call can also be configured. The options are:

- always_inspect
- always_ignore
- ignore_implicit (without curly braces)
- ignore_explicit (with curly braces)

Example:

# EnforcedHashRocketStyle: key (default)
# EnforcedColonStyle: key (default)

# good
{
  foo: bar,
  ba: baz
}
{
  :foo => bar,
  :ba => baz
}

# bad
{
  foo: bar,
   ba: baz
}
{
  :foo => bar,
   :ba => baz
}

Example:

# EnforcedHashRocketStyle: separator
# EnforcedColonStyle: separator

#good
{
  foo: bar,
   ba: baz
}
{
  :foo => bar,
   :ba => baz
}

#bad
{
  foo: bar,
  ba: baz
}
{
  :foo => bar,
  :ba => baz
}
{
  :foo => bar,
  :ba  => baz
}

Example:

# EnforcedHashRocketStyle: table
# EnforcedColonStyle: table

#good
{
  foo: bar,
  ba:  baz
}
{
  :foo => bar,
  :ba  => baz
}

#bad
{
  foo: bar,
  ba: baz
}
{
  :foo => bar,
   :ba => baz
}

Line is too long. [86/80]
Open

        create(:availability, person: person_from_different_dept, status: 'Available',
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Line is too long. [85/80]
Open

        within("table#event-status tr##{@response_team.name.parameterize}-status") do
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Line is too long. [83/80]
Open

          expect(page).to have_css('.event-labels[title="Unavailable"]', text: '0')
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Line is too long. [94/80]
Open

          expect(page).to have_css('.event-labels[title="Assigned to THIS Event"]', text: '0')
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Line is too long. [91/80]
Open

          expect(page).to have_css('.event-labels[title="Partially Available"]', text: '0')
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Line is too long. [88/80]
Open

        create(:availability, person: person_from_different_dept, status: 'Unavailable',
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

        within("table#availabilities") do
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Line is too long. [83/80]
Open

          expect(page).to have_css('.event-labels[title="Unavailable"]', text: '1')
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

        within("table#generic-people") do
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Line is too long. [94/80]
Open

          expect(page).to have_css('.event-labels[title="Assigned to THIS Event"]', text: '0')
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

        within("table#availabilities") do
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Line is too long. [83/80]
Open

          expect(page).to have_css('.event-labels[title="No Response"]', text: '0')
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Line is too long. [91/80]
Open

          expect(page).to have_css('.event-labels[title="Partially Available"]', text: '0')
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Line is too long. [83/80]
Open

          expect(page).to have_css('.event-labels[title="No Response"]', text: '1')
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Line is too long. [87/80]
Open

        within("table#event-status tr##{@medical_reserve.name.parameterize}-status") do
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Line is too long. [81/80]
Open

        no_response = create(:person, department: @response_team, title_order: 3)
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

        within("table#availabilities") do
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Line is too long. [85/80]
Open

        within("table#event-status tr##{@response_team.name.parameterize}-status") do
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Line is too long. [83/80]
Open

          expect(page).to have_css('.event-labels[title="Unavailable"]', text: '0')
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

        within("table#availabilities") do
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Line is too long. [83/80]
Open

          expect(page).to have_css('.event-labels[title="No Response"]', text: '0')
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Line is too long. [85/80]
Open

        within("table#event-status tr##{@response_team.name.parameterize}-status") do
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Line is too long. [81/80]
Open

          expect(page).to have_css('.event-labels[title="Available"]', text: '0')
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Line is too long. [83/80]
Open

          expect(page).to have_css('.event-labels[title="Unavailable"]', text: '0')
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Line is too long. [91/80]
Open

          expect(page).to have_css('.event-labels[title="Partially Available"]', text: '0')
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

        within("table#availabilities") do
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Missing magic comment # frozen_string_literal: true.
Open

require 'rails_helper'
Severity: Minor
Found in spec/features/events/event_page_spec.rb by rubocop

This cop is designed to help upgrade to Ruby 3.0. It will add the comment # frozen_string_literal: true to the top of files to enable frozen string literals. Frozen string literals may be default in Ruby 3.0. The comment will be added below a shebang and encoding comment. The frozen string literal comment is only valid in Ruby 2.3+.

Example: EnforcedStyle: when_needed (default)

# The `when_needed` style will add the frozen string literal comment
# to files only when the `TargetRubyVersion` is set to 2.3+.
# bad
module Foo
  # ...
end

# good
# frozen_string_literal: true

module Foo
  # ...
end

Example: EnforcedStyle: always

# The `always` style will always add the frozen string literal comment
# to a file, regardless of the Ruby version or if `freeze` or `<<` are
# called on a string literal.
# bad
module Bar
  # ...
end

# good
# frozen_string_literal: true

module Bar
  # ...
end

Example: EnforcedStyle: never

# The `never` will enforce that the frozen string literal comment does
# not exist in a file.
# bad
# frozen_string_literal: true

module Baz
  # ...
end

# good
module Baz
  # ...
end

There are no issues that match your filters.

Category
Status