Sign upLogin

RebelCode/expression-wp-query-builder-abstract

View on GitHub
Star
src/GetWpQueryMetaCompareOperatorCapableTrait.php

Summary

Maintainability
A
55 mins
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    protected function _getWpQueryMetaCompareOperator(LogicalExpressionInterface $expression)
    {
        $key = $this->_normalizeString($expression->getType());
        $neg = ((int) $expression->isNegated()) % 2;
Severity: Minor
Found in src/GetWpQueryMetaCompareOperatorCapableTrait.php and 1 other location - About 55 mins to fix
src/GetWpQueryTaxCompareOperatorCapableTrait.php on lines 44..59

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 99.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid using short method names like GetWpQueryMetaCompareOperatorCapableTrait::__(). The configured minimum method name length is 3.
Open

    abstract protected function __($string, $args = [], $context = null);
Severity: Minor
Found in src/GetWpQueryMetaCompareOperatorCapableTrait.php by phpmd

ShortMethodName

Since: 0.2

Detects when very short method names are used.

Example

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Source https://phpmd.org/rules/naming.html#shortmethodname

The method __ is not named in camelCase.
Open

    abstract protected function __($string, $args = [], $context = null);
Severity: Minor
Found in src/GetWpQueryMetaCompareOperatorCapableTrait.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status