Sign upLogin

RebelCode/migrations

View on GitHub
Star

Showing 15 of 15 total issues

Method getVersion has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getVersion()
    {
        $result     = [];
        $versionCol = $this->_getLogTableVersionColumn();
        $statusCol  = $this->_getLogTableStatusColumn();
Severity: Minor
Found in src/AbstractDatabase.php - About 1 hr to fix

    Avoid using short method names like MySqlFormatMigrator::up(). The configured minimum method name length is 3.
    Open

        public function up($version = null, $force = false)
    {
        $this->_up($version);
    }
    Severity: Minor
    Found in src/MySqlFormatMigrator.php by phpmd

    ShortMethodName

    Since: 0.2

    Detects when very short method names are used.

    Example

    class ShortMethod {
    public function a( $index ) { // Violation
    }
}

    Source https://phpmd.org/rules/naming.html#shortmethodname

    Avoid using short method names like MigratorAwareTrait::__(). The configured minimum method name length is 3.
    Open

        abstract protected function __($string, $args = [], $context = null);
    Severity: Minor
    Found in src/MigratorAwareTrait.php by phpmd

    ShortMethodName

    Since: 0.2

    Detects when very short method names are used.

    Example

    class ShortMethod {
    public function a( $index ) { // Violation
    }
}

    Source https://phpmd.org/rules/naming.html#shortmethodname

    Avoid using short method names like AbstractMigrator::__(). The configured minimum method name length is 3.
    Open

        abstract protected function __($string, $args = [], $context = null);
    Severity: Minor
    Found in src/AbstractMigrator.php by phpmd

    ShortMethodName

    Since: 0.2

    Detects when very short method names are used.

    Example

    class ShortMethod {
    public function a( $index ) { // Violation
    }
}

    Source https://phpmd.org/rules/naming.html#shortmethodname

    Avoid using short method names like MigratorInterface::up(). The configured minimum method name length is 3.
    Open

        public function up($version = null);
    Severity: Minor
    Found in src/MigratorInterface.php by phpmd

    ShortMethodName

    Since: 0.2

    Detects when very short method names are used.

    Example

    class ShortMethod {
    public function a( $index ) { // Violation
    }
}

    Source https://phpmd.org/rules/naming.html#shortmethodname

    Avoid variables with short names like $db. Configured minimum length is 3.
    Open

                $db = $this->getDbCommand();
    Severity: Minor
    Found in src/AbstractMigrator.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $db. Configured minimum length is 3.
    Open

        public function __construct(UriInterface $uri, DatabaseInterface $db, $baseDir, $formatters = [])
    Severity: Minor
    Found in src/MySqlFormatMigrator.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            $message = null,
        $code = null,
        RootException $previous = null,
        $migrator = null,
        $migrationVersion = null
    Severity: Minor
    Found in src/Exception/CouldNotMigrateException.php - About 35 mins to fix

      The method _down has a boolean flag argument $force, which is a certain sign of a Single Responsibility Principle violation.
      Open

          protected function _down($upVersion = null, $force = false)
      Severity: Minor
      Found in src/AbstractMigrator.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
    public function bar($flag = true) {
    }
}

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      The method _up has a boolean flag argument $force, which is a certain sign of a Single Responsibility Principle violation.
      Open

          protected function _up($upVersion = null, $force = false)
      Severity: Minor
      Found in src/AbstractMigrator.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
    public function bar($flag = true) {
    }
}

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      The method up has a boolean flag argument $force, which is a certain sign of a Single Responsibility Principle violation.
      Open

          public function up($version = null, $force = false)
      Severity: Minor
      Found in src/MySqlFormatMigrator.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
    public function bar($flag = true) {
    }
}

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      The method down has a boolean flag argument $force, which is a certain sign of a Single Responsibility Principle violation.
      Open

          public function down($version = null, $force = false)
      Severity: Minor
      Found in src/MySqlFormatMigrator.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
    public function bar($flag = true) {
    }
}

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      Avoid using static access to class '\ByJG\AnyDataset\Factory' in method 'prepareEnvironment'.
      Open

              $dbDriver  = Factory::getDbRelationalInstance($customUri->withPath('/')->__toString());
      Severity: Minor
      Found in src/MySqlDatabase.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      The method __ is not named in camelCase.
      Open

          abstract protected function __($string, $args = [], $context = null);
      Severity: Minor
      Found in src/MigratorAwareTrait.php by phpmd

      CamelCaseMethodName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name methods.

      Example

      class ClassName {
    public function get_name() {
    }
}

      Source

      The method __ is not named in camelCase.
      Open

          abstract protected function __($string, $args = [], $context = null);
      Severity: Minor
      Found in src/AbstractMigrator.php by phpmd

      CamelCaseMethodName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name methods.

      Example

      class ClassName {
    public function get_name() {
    }
}

      Source

      Severity
      Category
      Status
      Source
      Language