RebelCode/module-iterator-abstract

View on GitHub

Showing 14 of 14 total issues

The variable $_this is not named in camelCase.
Open

    protected function _getUnservedModuleDependencies(ModuleInterface $module)
    {
        $_this        = $this;
        $dependencies = $this->_getModuleDependencies($module);

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $_this is not named in camelCase.
Open

    protected function _getUnservedModuleDependencies(ModuleInterface $module)
    {
        $_this        = $this;
        $dependencies = $this->_getModuleDependencies($module);

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The method _getDeepMostUnservedModuleDependency is not named in camelCase.
Open

    protected function _getDeepMostUnservedModuleDependency(ModuleInterface $module, $ignore = array())
    {
        $moduleKey          = $module->getKey();
        $ignore[$moduleKey] = $module;
        $dependencies       = $this->_getUnservedModuleDependencies($module);

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _setModules is not named in camelCase.
Open

    protected function _setModules($modules)
    {
        $this->moduleIterator = $this->_normalizeIterator($modules);
    }

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _isModuleServed is not named in camelCase.
Open

    protected function _isModuleServed($key)
    {
        return isset($this->servedModules[$key]);
    }

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _rewind is not named in camelCase.
Open

    protected function _rewind()
    {
        $this->servedModules = array();
        $this->current       = null;
        $this->moduleIterator->rewind();

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _key is not named in camelCase.
Open

    protected function _key()
    {
        return ($this->current !== null)
            ? $this->current->getKey()
            : null;

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _next is not named in camelCase.
Open

    protected function _next()
    {
        $previous = $this->current;

        // Mark the previous module as served

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _valid is not named in camelCase.
Open

    protected function _valid()
    {
        return $this->current !== null;
    }

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _getModuleDependencies is not named in camelCase.
Open

    abstract protected function _getModuleDependencies(ModuleInterface $module);

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _markModuleAsServed is not named in camelCase.
Open

    protected function _markModuleAsServed(ModuleInterface $module)
    {
        $this->servedModules[$module->getKey()] = $module;

        return $this;

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _getUnservedModuleDependencies is not named in camelCase.
Open

    protected function _getUnservedModuleDependencies(ModuleInterface $module)
    {
        $_this        = $this;
        $dependencies = $this->_getModuleDependencies($module);

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _current is not named in camelCase.
Open

    protected function _current()
    {
        return $this->current;
    }

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _normalizeIterator is not named in camelCase.
Open

    abstract protected function _normalizeIterator($iterable);

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

Severity
Category
Status
Source
Language