Sign upLogin

RebelCode/rcmod-eddbk-admin-emails

View on GitHub
Star

Showing 8 of 8 total issues

Avoid excessively long variable names like $bookingDateTimeFormat. Keep variable name length under 20.
Open

        $bookingDateTimeFormat
Severity: Minor
Found in src/Module/BookingsEmailTagTemplate.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $bookingDateTimeFormat. Keep variable name length under 20.
Open

    protected $bookingDateTimeFormat;
Severity: Minor
Found in src/Module/BookingsEmailTagTemplate.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Method _renderBooking has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function _renderBooking($booking)
    {
        $serviceId = $booking->getState()->get('service_id');

        // Create date time helper instance for the booking start time
Severity: Minor
Found in src/Module/BookingsEmailTagTemplate.php - About 1 hr to fix

    Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            $key,
        $dependencies,
        $configFactory,
        $containerFactory,
        $compContainerFactory,
    Severity: Major
    Found in src/Module/EddBkAdminEmailsModule.php - About 50 mins to fix

      Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              TemplateInterface $layoutTemplate,
        BookingFactoryInterface $bookingFactory,
        GetCapableManagerInterface $servicesManager,
        GetCapableManagerInterface $resourcesManager,
        CacheContainerInterface $serviceCache,
      Severity: Major
      Found in src/Module/BookingsEmailTagTemplate.php - About 50 mins to fix

        Avoid variables with short names like $b. Configured minimum length is 3.
        Open

                $b = $this->exprBuilder;
        Severity: Minor
        Found in src/Module/BookingsEmailTag.php by phpmd

        ShortVariable

        Since: 0.2

        Detects when a field, local, or parameter has a very short name.

        Example

        class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

        Source https://phpmd.org/rules/naming.html#shortvariable

        Avoid variables with short names like $c. Configured minimum length is 3.
        Open

            public function run(ContainerInterface $c = null)
        Severity: Minor
        Found in src/Module/EddBkAdminEmailsModule.php by phpmd

        ShortVariable

        Since: 0.2

        Detects when a field, local, or parameter has a very short name.

        Example

        class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

        Source https://phpmd.org/rules/naming.html#shortvariable

        Avoid using static access to class '\Carbon\Carbon' in method '_renderBooking'.
        Open

                $startDt = Carbon::createFromTimestampUTC($startTs);
        Severity: Minor
        Found in src/Module/BookingsEmailTagTemplate.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Severity
        Category
        Status
        Source
        Language