RebelCode/rcmod-eddbk-booking-logic

View on GitHub
src/EddBkBookingLogicModule.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method setup has 67 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function setup()
    {
        return $this->_setupContainer(
            $this->_loadPhpConfigFile(EDDBK_BOOKING_LOGIC_MODULE_CONFIG),
            [
Severity: Major
Found in src/EddBkBookingLogicModule.php - About 2 hrs to fix

    Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            $key,
            $dependencies,
            $configFactory,
            $containerFactory,
            $compContainerFactory,
    Severity: Major
    Found in src/EddBkBookingLogicModule.php - About 50 mins to fix

      Avoid variables with short names like $c. Configured minimum length is 3.
      Open

          public function run(ContainerInterface $c = null)
      Severity: Minor
      Found in src/EddBkBookingLogicModule.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
          private $q = 15; // VIOLATION - Field
          public static function main( array $as ) { // VIOLATION - Formal
              $r = 20 + $this->q; // VIOLATION - Local
              for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                  $r += $this->q;
              }
          }
      }

      Source https://phpmd.org/rules/naming.html#shortvariable

      There are no issues that match your filters.

      Category
      Status